Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Knapsack problem interface #55

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Added Knapsack problem interface #55

merged 4 commits into from
Oct 9, 2024

Conversation

zaibod
Copy link
Contributor

@zaibod zaibod commented Sep 10, 2024

No description provided.

@koalamitice koalamitice self-requested a review September 11, 2024 11:13
Copy link
Member

@koalamitice koalamitice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem mask looks good. Some changes to the tags and problem descritption are needed.

I also noticed some interesting behavior when creating new knapsack problems.
For instance:
2
1 2 3
2 3 5
10
works for the HS-solver, but not for qiskit. Our example test case runs for both. Ill create an issue in the toolbox-server for this.

src/components/landing-page/ProblemChooser.tsx Outdated Show resolved Hide resolved
src/pages/solve/Knapsack.tsx Outdated Show resolved Hide resolved
src/pages/solve/Knapsack.tsx Outdated Show resolved Hide resolved
Copy link

@Elscrux Elscrux self-requested a review October 9, 2024 10:26
@Elscrux Elscrux merged commit 30fa3bf into develop Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants