Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 faq how do i find my session id in posit workbench #104

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

JFix89
Copy link
Contributor

@JFix89 JFix89 commented Mar 6, 2024

Pull Request Details

Issue Number: Closes #49 and #103

Type: Documentation

Description of the Change

Updated FAQs.md to add guidance on how to find a Posit Workbench session ID. This content had already been reviewed for issue #49 but not merged at the time. Instead of adding to a dedicated markdown file in the technical documentation, this content is now being added to the new 'Sessions' section of the FAQs file.

Verification Process

N/A

Additional Work Required

N/A

Release Notes

Updated FAQs.md to add guidance on how to find a Posit Workbench session ID

@JFix89 JFix89 requested review from rmccreath and alasdairgm March 6, 2024 15:23
@JFix89 JFix89 linked an issue Mar 6, 2024 that may be closed by this pull request
Copy link
Contributor

@alasdairgm alasdairgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a spotted typo and a minor suggestion from me!

Posit Infrastructure/FAQs.md Outdated Show resolved Hide resolved
Posit Infrastructure/FAQs.md Outdated Show resolved Hide resolved
Copy link
Member

@rmccreath rmccreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, happy to approve.

Just to add though, I think the wording was extended out as it was it's own document, so could potentially be reduced to something like intro text, point 2 and the alternative method?

@JFix89
Copy link
Contributor Author

JFix89 commented Mar 6, 2024

Thanks both for reviewing, I've made the changes to the text that @alasdairgm suggested. @rmccreath : Although I agree it's on the long side, I think it provides a good amount of detail for beginners, so I'm tempted to leave it as it is for now. Happy to revisit this at a later point if we need to cut down content in the FAQs.md file though!

@JFix89 JFix89 merged commit 797e956 into main Mar 6, 2024
1 check passed
@JFix89 JFix89 deleted the 103-faq-how-do-i-find-my-session-id-in-posit-workbench branch March 6, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants