Skip to content

Commit

Permalink
Merge branch 'main' into tab-component-change-css
Browse files Browse the repository at this point in the history
  • Loading branch information
zoltan-dulac authored Jan 28, 2025
2 parents ffacb31 + 11b8024 commit 590f74f
Show file tree
Hide file tree
Showing 72 changed files with 1,453 additions and 218 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/push-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ jobs:
architecture: x64
- name: Install Lynx dependency
run: sudo apt install lynx
- name: Install PHP8.1
run: sudo apt install php8.1
- name: Install PHP
run: sudo apt install php
- name: Install latest Chrome to match chromedriver package version
# Note: you should see if the version of Chrome matches the latest listed on
# https://mirror.cs.uchicago.edu/google-chrome/pool/main/g/google-chrome-stable/
run: |
apt search '^google-chrome.*' \
&& wget -q -O /tmp/chrome.deb http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_130.0.6723.58-1_amd64.deb \
&& wget -q -O /tmp/chrome.deb https://mirror.cs.uchicago.edu/google-chrome/pool/main/g/google-chrome-stable/google-chrome-stable_132.0.6834.110-1_amd64.deb \
&& sudo apt install -y /tmp/chrome.deb --allow-downgrades \
&& rm /tmp/chrome.deb
- name: Log system details
Expand Down
55 changes: 55 additions & 0 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
module.exports = {
"customSyntax": "postcss-less",
"extends": [ "stylelint-config-standard"],
"ignoreFiles": [
"**/*.js",
"enable-node-libs/**/*.css",
"js/out/**/*.css",
"js/enable-libs/**/*.css"
],
"plugins": ["@double-great/stylelint-a11y"],
"rules": {
"a11y/no-text-align-justify": true,
"alpha-value-notation": null,
"at-rule-empty-line-before": null,
"at-rule-no-unknown": null,
"color-function-notation": null,
"color-hex-length": null,
"comment-empty-line-before": null,
"comment-whitespace-inside": null,
"custom-property-empty-line-before": null,
"custom-property-pattern": null,
"declaration-empty-line-before": null,
"declaration-block-no-duplicate-properties": null,
"declaration-block-no-redundant-longhand-properties": null,
"declaration-block-no-shorthand-property-overrides": null,
"declaration-block-single-line-max-declarations": null,
"font-family-name-quotes": null,
"font-family-no-missing-generic-family-keyword": null,
"function-calc-no-unspaced-operator": null,
"function-name-case": null,
"function-no-unknown": null,
"function-url-quotes": null,
"hue-degree-notation": null,
"import-notation": null,
"keyframes-name-pattern": null,
"length-zero-no-unit": null,
"media-feature-range-notation": null,
"media-query-no-invalid": null,
"no-empty-source": null,
"no-descending-specificity": null,
"no-duplicate-selectors": null,
"number-max-precision": null,
"property-no-unknown": null,
"property-no-vendor-prefix": null,
"rule-empty-line-before": null,
"selector-class-pattern": null,
"selector-id-pattern": null,
"selector-no-vendor-prefix": null,
"selector-pseudo-element-colon-notation": null,
"shorthand-property-no-redundant-values": null,
"string-no-newline": null,
"value-keyword-case": null,
"value-no-vendor-prefix": null
}
}
2 changes: 2 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
"js/out/**/*.css",
"js/enable-libs/**/*.css"
],
"plugins": ["@double-great/stylelint-a11y"],
"rules": {
"a11y/no-text-align-justify": true,
"alpha-value-notation": null,
"at-rule-empty-line-before": null,
"at-rule-no-unknown": null,
Expand Down
6 changes: 6 additions & 0 deletions bin/checkHTML.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ If that does not work, you may need to do a global update of @axe-core/cli:
sudo npm update -g @axe-core/cli
********************************************************************************
* NOTE: If you are seeing this message in GitHub Automated Tests, you need to
* update push-actions.yml to ensure the version of Chrome being downloaded there
* matches the one in your package.json
********************************************************************************
' 1>&2
exit 1;
Expand Down
361 changes: 361 additions & 0 deletions content/body/accessible-pdf-generation.php

Large diffs are not rendered by default.

45 changes: 24 additions & 21 deletions content/body/acknowledgements.php
Original file line number Diff line number Diff line change
@@ -1,29 +1,43 @@
<p>
Originally, Enable started out as a small personal website to help me show other developers how accessible code is
structured.
Some of the solutions are my own, and some I have borrowed from others (because why reinvent the wheel, especially when
you have already learned from the best?)
Originally, Enable started out as a small personal website made by <a href="https://www.useragentman.com/">Zoltan Hawryluk</a> to show other developers how to make web-related code accessible to people with disabalities. Some of the solutions were his own, and some he have borrowed, with citations, from others. Zoltan is still the lead developer of this project and often contributes his own code to it, as well as reviewing all contributions from the community.
</p>

<p>Today, Enable is now sponsored by The Publicis Sapient Accessibility Center of Excellence, to help not only its developers make accessible things, but also to give back to the accessibility and front-end web development communities. It contains contributions from developers within Publicis Sapient as well as others, and we hope to continue to grow this ongoing collaboration.</p>

<p>
What follows are not just acknowledgements to existing accessible code examples used in Enable, but also to other code I have
What follows are not just acknowledgements to existing accessible code examples used in Enable, but also to other code we have
built on that I have accessibility features to.
</p>

<h2>Direct Contributers</h2>


<p>
The following people have contributed directly to the Enable project by adding code/content via pull requests.
The following people have contributed directly to the Enable project by adding code/content via pull requests or by direct collaboration.
</p>

<ul>
<li>
<a href="https://twitter.com/lsnrae">Alison Walden</a> for her UX guidelines for both <a
href="https://lsnrae.medium.com/if-you-must-use-a-carousel-make-it-accessible-977afd0173f4">accessible
carousels</a> and <a href="https://lsnrae.medium.com/accessible-form-validation-9fa637ddb0fc">form validation</a>.
</li>
<li><a href="https://github.com/saumyajitc">Saumyajit Chowdhury</a> for implementing husky pre-commit hooks to run lint-staged before pushing code to the repository</li>
<li><a href="https://github.com/majid-paktinat">Majid Paktinat</a> and <a href="https://github.com/akshaypanchal">Akshaykumar Panchal</a> for implementing dynamic Structured Data Markup for improving the SEO of the Enable Project.</li>
<li><a href="https://github.com/basiabaldwin">Basia Baldwin</a> for working on redesigning the Enable project and developing the site in dark mode.</li>
<li><a href="https://github.com/alisonhall">Alison Hall</a> for cleaning up and streamlining the unit testing and automated testing NPM tasks (and also doing the difficult task of updating the NPM packages within the project in 2024).
</li>
<li>Matthew Slavin for his redesign of the Enable Project's website in 2024, and to <a href="https://github.com/basiabaldwin">Basia Baldwin</a> and Travis Doughty for for implementing the redesign on the site. </li>
<li><a href="https://github.com/alisonhall">Alison Hall</a> for cleaning up and streamlining the unit testing and automated testing NPM tasks (and also doing the difficult task of updating the NPM packages within the project in 2024). She also added the Table of Contents component that appears on the top of almost every Enable page.</li>
<li>Oluwaseun Longe for adding stylelint to Enable.</li>
<li>Sahil Singh for unit tests for the <a href="input-mask.php">input mask component</a>.</li>
<li><a href="https://www.useragentman.com/">Zoltan Hawryluk</a> for starting the Enable project to begin with.</li>
<li>Noel Tibbles and Yash Narang for contributing to <a href="https://github.com/PublicisSapient/enable-a11y-react">the React version of Enable</a> (still in beta). Noel has also created the <a href="https://github.com/PublicisSapient/enable-a11y-web-components">Enable's HTML5 Web Components</a>, also in beta.</li>
<li><a href="https://github.com/saumyajitc">Saumyajit Chowdhury</a> for implementing deployment procedures in <a href="https://enable-a11y-react-iqpmwl8kb-publicis-sapient-sandbox.vercel.app/">Vercel</a> for <a href="https://github.com/PublicisSapient/enable-a11y-react">the React version of Enable</a> and create npm package for external use of the accessible components.</li>
<li><a href="https://github.com/akr3081">Adam Rock</a> for the accessible <a href="/meter.php">meter</a> and <a href="/audio-player.php">audio player</a> components
</li>
<li><a href="https://github.com/shiprarawal/shiprarawal">Shipra Rawal</a> for our <a href="infographics.php">Infographics page</a>.</li>
<li><a href="https://github.com/lunarias">Jessie Cai</a> for our <a href="tooltip.php">Tooltips page</a> and adding fixes for running Enable locally on a Windows machine.</li>
<li>Mahesh Ambig for the unit tests for the Tab Component.</li>
<li>Neha Singla for the unit tests for the Combobox Component.</li>
</ul>

<h2>Code Used By Enable</h2>
Expand All @@ -33,15 +47,7 @@
</p>

<ul>
<li><a href="https://github.com/saumyajitc">Saumyajit Chowdhury</a> for implementing deployment procedures in <a href="https://enable-a11y-react-iqpmwl8kb-publicis-sapient-sandbox.vercel.app/" target="new">Vercel</a> for <a href="https://github.com/PublicisSapient/enable-a11y-react" target="new">Enable(react version)</a> and create npm package for external use of the accessible components.</li>
<li><a href="https://twitter.com/lsnrae">Alison Walden</a> for her UX guidelines for both <a
href="https://lsnrae.medium.com/if-you-must-use-a-carousel-make-it-accessible-977afd0173f4">accessible
carousels</a> and <a href="https://lsnrae.medium.com/accessible-form-validation-9fa637ddb0fc">form validation</a>
</li>
<li><a href="https://github.com/alisonhall">Alison Hall</a> for cleaning up and streamlining the unit testing and automated testing NPM tasks (and also doing the difficult task of updating the NPM packages within the project in 2024).
</li>
<li><a href="https://github.com/akr3081">Adam Rock</a> for the accessible <a href="/meter.php">meter</a> and <a href="/audio-player.php">audio player</a> components
</li>


<li><a href="https://code.iamkate.com">Kate Morley</a> for her <a
href="https://code.iamkate.com/html-and-css/styling-checkboxes-and-radio-buttons/">ARIA radio buttons</a>
Expand Down Expand Up @@ -139,9 +145,6 @@
<li><a href="https://zellwk.com/">Zell Liew</a> for
the routine for <a href="https://github.com/zellwk/javascript/blob/master/src/browser/accessibility/focusable/focusable.js">
getting all the focusable elements inside a DOM element</a> that <code>accessibility.getAlTabbableEls()</code> is based on.</li>
<li><a href="https://github.com/lunarias">Jessie Cai</a> for
adding additional functionality and cleaning up <a href="https://github.com/PublicisSapient/enable-a11y/blob/main/js/modules/tooltip.js">tooltip control</a>
</li>
</ul>

<h2>Icons</h2>
Expand Down
17 changes: 1 addition & 16 deletions content/body/combobox.php
Original file line number Diff line number Diff line change
Expand Up @@ -471,22 +471,7 @@
<script type="application/json" id="submit-on-select-example-props">
{
"replaceHtmlRules": {
"[role=\"listbox\"]": [
"<div class=\"enable-combobox__group\" role=\"presentation\">",
"<h2 class=\"enable-combobox__group-header\">Communist States</h2>",
"",
"<div role=\"option\" >People's Republic of China</div>",
"",
"...",
"",
"</div>",
"<div class=\"enable-combobox__group\" role=\"presentation\">",
"<h2 class=\"enable-combobox__group-header\">Other States</h2>",
"<div role=\"option\" >Afghanistan</div>",
"",
"...",
"</div>"
]
"[role=\"listbox\"]": "<li role=\"option\" value=\"1942\">1942</li><li role=\"option\" value=\"Asteroids\">Asteroids</li> ..."
},
"steps": [{
"label": "Create JavaScript code to submit query when clicking the option elements.",
Expand Down
Loading

0 comments on commit 590f74f

Please sign in to comment.