CMake fixes #527
Open
CMake fixes #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark HAVE_P8_USB_DETECT as internal (no way to define it externally), Always enable HAVE_P8_USB_DETECT on linux (for SYSFS detection), Fixed CMAKE_REQUIRED_LIBRARIES if libudev is used.
Avoid resolving variable otherwise variable content could be treated as name of another variable
…ing description "Linux supported: no" description could mislead users
…CHE var, added description
|
@malard @opdenkamp any updates on this? |
|
sorry for the delay in reviewing this, I will get @opdenkamp to review this later this week |
Thanks, this would be great. |
|
Hi @opdenkamp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
While working on new ebuild version for Gentoo (Gentoo package), I discovered that .cmake files override cache variable values by using
FORCEoption (which is not recommended) therefore breaking idea of providing correct value at configure time by-DHAVE_SOMETHING=ON(orOFF).I've made corrections and fixed some minor things.
Hope you'll find it useful.