Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows-specific tree_hash issue #2

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Windows-specific tree_hash issue #2

merged 3 commits into from
Feb 8, 2024

Conversation

MichaelHatherly
Copy link
Collaborator

@MichaelHatherly MichaelHatherly commented Feb 8, 2024

Fixes #1.

@MichaelHatherly MichaelHatherly marked this pull request as draft February 8, 2024 14:54
Interpolation a `Function` results in interpolating the literal name without error unless the user does not have `openssl` on their `PATH`. Call the function instead.
`GitTools.tree_hash` was giving what appears to be an incorrect result on
Windows. Use `git` directly to get the right hash instead.
@MichaelHatherly MichaelHatherly changed the title Set core.autocrlf false to try and fix #1 Windows-specific tree_hash issue Feb 8, 2024
@MichaelHatherly MichaelHatherly marked this pull request as ready for review February 8, 2024 17:45
@MichaelHatherly MichaelHatherly merged commit 832168f into main Feb 8, 2024
4 checks passed
@MichaelHatherly MichaelHatherly deleted the mh/crlf branch February 8, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows-specific git object <commit> could not be found
1 participant