Only execute rbenv-which if the result is used #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing the nodenv-env fork of this, I discovered that the rbenv-which command fails when a ruby version isn't set. Since the result of that command is only used when a ruby version is explicitly set, it doesn't make sense to attempt the command in all cases (especially when it fails in the negative case). Related to rbenv/rbenv#865
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing the nodenv-env fork of this, I discovered that the rbenv-which command fails when a ruby version isn't set. Since the result of that command is only used when a ruby version is explicitly set, it doesn't make sense to attempt the command in all cases (especially when it fails in the negative case).
Related to rbenv/rbenv#865