Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dj mix app to run in the browser without using pc #329

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abadoni5
Copy link
Contributor

@abadoni5 abadoni5 commented Mar 11, 2024

Summary

#218 the original lessons uses Tkinter GUI which requires pc to run, I solved that issue making the code run natively in browser.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

Screenshot 2024-03-11 at 2 26 41 PM

@abadoni5 abadoni5 changed the title updates dj mix app to run in the browser without using pc updated dj mix app to run in the browser without using pc Mar 11, 2024
Copy link

@abadoni5
Copy link
Contributor Author

@NicolasSandoval @reingart I tried implementing this idea. Please have a look, I am open to suggestions and possible errors in my approach.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant