Fix bug where selecting 'Remote' work type incorrectly sets 'Allows r…

…emote work' to NO (issue #589) (#591)

* Add help text and fix URL validation to prepend https:// if missing

* Fix remote work issue (#589): Set 'allows remote work' flag to Yes when 'Remote' is selected

joboffers/models.py

@@ -223,6 +223,10 @@ def save(self, *args, **kwargs):
 
         super().save(*args, **kwargs)
 
+    @property
+    def allows_remote_work(self):
+        return self.remoteness == Remoteness.REMOTE
+
     @classmethod
     def get_options(cls):
         """

joboffers/templates/joboffers/joboffer_overview.html

@@ -24,7 +24,7 @@ <h4 class="mt-0">
     </dd>
   {% endif %}
   <dt>Permite trabajar remoto</dt>
-  <dd>{% if obj.remote_work %}Si{% else %}No{% endif %}</dd>
+  <dd>{% if obj.allows_remote_work %}Sí{% else %}No{% endif %}</dd>
 
   <dt>Experiencia Requerida</dt>
   <dd>{{ obj.get_experience_display }}</dd>

pycompanies/forms.py

@@ -1,6 +1,7 @@
 from django import forms
 from django_summernote.widgets import SummernoteInplaceWidget
 from django.utils.translation import gettext_lazy as _
+from urllib.parse import urlparse
 
 from crispy_forms.helper import FormHelper
 from crispy_forms.layout import Div, ButtonHolder, Layout, Submit
@@ -12,6 +13,9 @@ class CompanyForm(forms.ModelForm):
     """A PyAr companies form."""
 
     description = forms.CharField(widget=SummernoteInplaceWidget())
+    link = forms.CharField(
+        help_text=_('Por favor, ingrese una URL válida con esquema (por ejemplo, https://).')
+    )
 
     def __init__(self, *args, **kwargs):
         super(CompanyForm, self).__init__(*args, **kwargs)
@@ -28,6 +32,12 @@ def __init__(self, *args, **kwargs):
             )
         )
 
+    def clean_link(self):
+        link = self.cleaned_data.get('link')
+        if link and not urlparse(link).scheme:
+            link = f'https://{link}'
+        return link
+
     class Meta:
         fields = ['name', 'photo', 'link', 'description']
         model = Company