Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major improvement to OSM-based electricity grid (e.g. preserves exact locations of substations and converters) #1375

Closed
wants to merge 10 commits into from

Conversation

bobbyxng
Copy link
Contributor

Changes proposed in this Pull Request

  • Major improvement to the OSM-based electricity grid
  • build_osm_network completely rewritten:
    • substantial speed improvements
    • Exact locations of original substations are preserved
    • Lines with identical geometries and voltages are aggregated (num_parallel is increased)
    • Lines overpassing "virtual nodes" (not actual substations as per OSM raw data) are merged, if their electric properties allow it (same voltage levels, same number of circuits)
    • Geometries are preserved. Method to extend line/link to the substation has been improved significantly. No "mess" inside of a substation cluster anymore.
    • Method to determine substation point improved, based on "Point of Inaccessibility" (PoI) method developed by Garcia-Castellanos & Lombardo 2007, doi.org/10.1080/14702540801897809 which ensures that an interior point in non-convex shapes is always found.
    • Clustering resolution has been sharpened from 5000 meter radius to only 500 meters, while still ensuring topological connectivity.
    • Single bus for each voltage level in each substation. Buses of different voltages are arranged in geometric shape (three buses form a triangle, see screenshot)
    • Transformers now have a capacity s_nom based on the maximum of connected capacity connected to each bus
    • Resolves many issues related around cross-border capacity, especially if the substation was located close to a border. @lindnemi @toniseibold @JulianGeis @nworbmot

Todo:

  • Validation runs still open

image

image

image

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: retrieve_cost_data, retrieve_cost_data, retrieve_cost_data
  • osm-interconnectors passed! ✅

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing osm-interconnectors (6b00178) with master (0026b0f).
Branch is 10 commits ahead and 0 commits behind.
Last updated on 2024-10-19 14:30:36 CEST.

@bobbyxng bobbyxng closed this Oct 22, 2024
@bobbyxng
Copy link
Contributor Author

Updated PR with additional features in PR #1384
Continue there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant