Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate, rename and check config entries #1514

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Jan 26, 2025

Add scheme for deprecating config entries and warn for config validation

This PR introduces specific warning classes for deprecated and invalid configuration entries. A scheme is proposed to deprecate and optionally rename config entries through the config/deprecations.yaml.

Like this snakemake raises:

  • a DeprecationConfigWarning for deprecated config entries
  • a InvalidConfigWarning for unsupported/invalid config entries which are not included in config.default.yaml

Testing

Added assertions to verify warning classes in:

  • test_config_deprecations()
  • test_config_invalid_entries()

Open points

  • extend this to capture scenario config.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

add check for validity of config entries
@FabianHofmann FabianHofmann requested review from fneum and lkstrp January 26, 2025 10:53
@FabianHofmann FabianHofmann changed the title add scheme to deprecate/rename config entries deprecate, rename and check config entries Jan 26, 2025
Copy link
Contributor

github-actions bot commented Jan 26, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • config-deprecations failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing config-deprecations (a848ea3) with master (c61f1a3).
Branch is 5 commits ahead and 0 commits behind.
Last updated on 2025-01-26 15:45:50 CET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant