Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(add_electricity): Fix nuclear p_max_pu time-series for greenfield nuclear #1519

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix(add_electricity): Fix nuclear p_max_pu time-series for greenfield nuclear #1519

merged 2 commits into from
Feb 6, 2025

Conversation

coroa
Copy link
Member

@coroa coroa commented Jan 29, 2025

Changes proposed in this Pull Request

If nuclear is only part of extendable carriers, but not of convential carriers, then the typical "conventional: nuclear: p_max_pu" setting writes the file name all over the p_max_pu time-series, breaking the add_electricity rule.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@coroa coroa requested a review from fneum January 29, 2025 19:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • fix-input-conventional failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix-input-conventional (91e61c8) with master (590b684).
Branch is 2 commits ahead and 0 commits behind.
Last updated on 2025-02-04 17:15:57 CET.

@coroa
fix(add_electricity): Fix nuclear p_max_pu time-series for greenfield…
0fd2279 
… nuclear

If nuclear is only part of extendable carriers, but not of convential carriers,
then the typical "conventional: nuclear: p_max_pu" setting writes the file name
all over the p_max_pu time-series, breaking the add_electricity rule.
@coroa coroa force-pushed the fix-input-conventional branch from c38f2e3 to 0fd2279 Compare January 29, 2025 19:39
@fneum fneum merged commit a12d724 into master Feb 6, 2025
14 checks passed
@fneum fneum deleted the fix-input-conventional branch February 6, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fneum fneum fneum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coroa @fneum @FabianHofmann