Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opta] Fix F24 timestamp parsing #288

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[Opta] Fix F24 timestamp parsing #288

merged 2 commits into from
Jan 22, 2024

Conversation

probberechts
Copy link
Contributor

Opta does not zero-pad milliseconds. Therefore, they were incorrectly parsed by Python's default "%f" format code.

See also #267

@probberechts
refactor(tests): Refactor Opta tests
25045aa
@probberechts
fix(opta): Fix Opta F24 timestamp parsing
25021d9 
Opta does not zero-pad milliseconds. Therefore, they were incorrectly parsed
by Python's default "%f" format code.

See also PySport#267
JanVanHaaren
JanVanHaaren approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@JanVanHaaren JanVanHaaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JanVanHaaren JanVanHaaren mentioned this pull request Jan 20, 2024
Merged
@koenvo koenvo added this to the 3.15 milestone Jan 22, 2024
@koenvo koenvo merged commit 401007a into PySport:master Jan 22, 2024
19 checks passed
@probberechts probberechts deleted the fix/opta-timestamps branch January 22, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanVanHaaren JanVanHaaren JanVanHaaren approved these changes

Assignees

@koenvo koenvo

Labels
None yet
Projects
None yet
Milestone
3.15
Development

Successfully merging this pull request may close these issues.
3 participants
@probberechts @JanVanHaaren @koenvo