Create standardized PositionType class #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Akkoord |
DriesDeprest
changed the title
DriesDeprest
changed the title
# Conflicts: # kloppy/tests/test_datafactory.py # kloppy/tests/test_opta.py # kloppy/tests/test_sportec.py
|
@koenvo let me know if you have feedback on the implementation! |
|
@JanVanHaaren do you think it matters that we lose the provider specific |
I don't think so. We're losing provider-specific information in other areas as well. |
|
@koenvo any other feedback or changes required to get this approved? |
|
Nope. LGTM. Thanks! |
koenvo
approved these changes
Aug 21, 2024
|
Hmm was merging PRs but seems there's a merge conflict. Are you able to resolve it, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to: #331.
I've replaced the Position with the 'standardized' PositionType class. I've refactored the StatsBomb deserializer and tests to work with the proposed changes.
I'm awaiting approval by @JanVanHaaren / @koenvo of the proposed implementation in this PR, before updating other serializers.