Fix rzz parameter validation on Qiskit 1.1 #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not add a release note because rzz gates are not available so far any way. |
The rzz validation check was using `CircuitInstruction.params`, an alias for `CircuitInstruction.operation.params` added in Qiskit 1.2. Here the usage is replaced `CircuitInstruction.operation.params` to keep compatibility with Qiskit 1.1.
wshanks
force-pushed
the
rzz-check-qiskit11
branch
from
3dfcc58 to
3e567d5
Compare
ihincks
reviewed
Oct 23, 2024
ihincks
approved these changes
Oct 23, 2024
|
I think it is fine to merge (I don't have permission to merge myself). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rzz validation check was using
CircuitInstruction.params, an alias forCircuitInstruction.operation.paramsadded in Qiskit 1.2. Here the usage is replacedCircuitInstruction.operation.paramsto keep compatibility with Qiskit 1.1.