Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization support for DoubleSliceSpan #1989

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

ihincks
Copy link
Collaborator

@ihincks ihincks commented Oct 22, 2024

Summary

This PR adds JSON serialization support for the DoubleSliceSpan object added in #1982 .

Details and comments

I notice now that SliceSpan uses "ExecutionSpan" and ExecutionSpans uses "ExecutionSpanCollection" as the json type keys: this is a mistake, but I chose to overlook it in this PR as being out-of-scope.

@ihincks ihincks requested a review from joshuasn October 22, 2024 14:55
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
test/unit/test_data_serialization.py Outdated Show resolved Hide resolved
@ihincks ihincks merged commit 9e3c397 into Qiskit:main Oct 22, 2024
19 checks passed
@ihincks ihincks deleted the serde-double_slice_span branch October 22, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants