-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify values of parametrized rzz gates #2021
Conversation
Following #2035, we should also take into account parameter expressions. |
A couple of comments:
|
Co-authored-by: Takashi Imamichi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But since I'm not an official approver, you need to ask someone else to review it too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add a release note?
Co-authored-by: Ian Hincks <[email protected]>
Co-authored-by: Ian Hincks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me except for a minor formatting change on the release note. I put in two other minor suggestions.
Co-authored-by: Will Shanks <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Summary
Fixes #2000.
This is only a draft. I forgot to write the tests before the code. So the current push contains the logic, but the tests will be added shortly.
Details and comments
@SamFerracin I have a question about the noise learner. I see that
NoiseLearner._run
callsvalidate_isa_circuits
, likeBasePrimitiveV2
. I added inBasePrimitivesV2
a call to a new function,validate_rzz_pubs
. But I'm not familiar enough with the noise learner to figure if a similar call should be added there too. I tried to add, butNoiseLearner._run
receives circuits, unlikeBasePrimitiveV2
, which receives pubs. Should I make_run
receive pubs and add the call to the new function?