Remove deprecated stochastic swap transpiler pass #13791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the stochastic swap transpiler pass and its associated routing stage plugin. This pass has been superseded by sabre at this point and it was deprecated in the Qiskit 1.3.0 release. Part of Qiskit#13699
|
One or more of the following people are relevant to this code:
|
mtreinish
added
the
Changelog: Removal
Pull Request Test Coverage Report for Build 13168305596Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jakelishman
reviewed
Feb 5, 2025
| target=backend.target | ||
| ) | ||
|
|
||
| this should be replaced with:: |
There was a problem hiding this comment.
Need to unindent this text line to separate the code blocks.
releasenotes/notes/remove-stochastic-swap-88e2d6be4c0d5713.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
108
to
110
| with warnings.catch_warnings(): | ||
| # TODO: remove this filter when StochasticSwap is removed | ||
| warnings.filterwarnings( | ||
| "ignore", | ||
| category=DeprecationWarning, | ||
| message=r".*StochasticSwap.*", | ||
| ) | ||
| # pylint: disable=not-callable | ||
| passmanager.append(self.pass_class(CouplingMap(coupling_map), **self.additional_args)) |
There was a problem hiding this comment.
Can remove the whole warnings.catch_warnings now too
Comment on lines
309
to
311
| with self.assertWarns(DeprecationWarning): | ||
| pass_ = SabreLayout( | ||
| cm, seed=0, routing_pass=StochasticSwap(cm, trials=1, seed=0, fake_run=True) | ||
| ) | ||
| pass_ = SabreLayout(cm, seed=0, routing_pass=BasicSwap(cm, fake_run=True)) | ||
| _ = pass_(qc) |
There was a problem hiding this comment.
This shouldn't warn now... I think it might be the duration thing inside the implicit dag_to_circuit from SabreLayout.__call__.
Co-authored-by: Jake Lishman <[email protected]>
|
Oh also I meant to write in the top review comment: we need to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes the stochastic swap transpiler pass and its associated routing stage plugin. This pass has been superseded by sabre at this point and it was deprecated in the Qiskit 1.3.0 release.
Details and comments
Part of #13699