Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake backends based on BackendV1 and related tools #13805

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Feb 6, 2025

Summary

This PR branches off #13793 and contains the changes related to the fake backend removal. This PR is built on top of #13722 and currently blocked by it.

Details and comments

TODOs:

  • remove stray prints
  • fix benchmarking test
  • fix visualization tests
  • reno

@coveralls
Copy link

coveralls commented Feb 10, 2025

Pull Request Test Coverage Report for Build 13242579073

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 265 of 276 (96.01%) changed or added relevant lines in 12 files are covered.
  • 994 unchanged lines in 40 files lost coverage.
  • Overall coverage decreased (-1.1%) to 87.206%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/circuit/add_control.py 20 21 95.24%
crates/accelerate/src/unitary_synthesis.rs 120 124 96.77%
crates/accelerate/src/two_qubit_decompose.rs 104 110 94.55%
Files with Coverage Reduction New Missed Lines %
qiskit/pulse/schedule.py 1 88.24%
qiskit/result/distributions/quasi.py 1 97.96%
qiskit/pulse/library/symbolic_pulses.py 1 94.82%
qiskit/pulse/instructions/acquire.py 1 89.13%
qiskit/utils/units.py 1 93.55%
qiskit/pulse/instructions/instruction.py 1 94.57%
crates/accelerate/src/unitary_synthesis.rs 1 93.4%
qiskit/primitives/backend_estimator_v2.py 1 97.71%
qiskit/transpiler/preset_passmanagers/builtin_plugins.py 1 95.69%
qiskit/pulse/library/waveform.py 1 97.83%
Totals Coverage Status
Change from base Build 13204846880: -1.1%
Covered Lines: 77268
Relevant Lines: 88604

💛 - Coveralls

@ElePT ElePT marked this pull request as ready for review February 11, 2025 12:51
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @enavarro51
  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @nkanazawa1989
  • @t-imamichi

@ElePT ElePT changed the title [WIP] Remove fake backends based on BackendV1 and related tools Remove fake backends based on BackendV1 and related tools Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants