[Fix] header position & input style 수정 #103

bokeeeey · 2024-06-21T18:46:35Z

🚀 작업 내용

드롭다운 xs사이즈 확인
input suffix 영역 확인
birth값 숫자만 받게 수정
헤더에 로그인 연결
로그인 상태에서 로그인 모달 안뜨게 처리
회원가입 로직 수정
드롭다운 스크롤 추가 => MaxHeight

✅ 체크리스트

Code Review 요청
Label 설정
PR 제목 규칙에 맞는지 확인

minjeong9919

새로 짜는 것보다 리팩토링하는게 더 힘드실텐데 정말 고생하셨습니다 ... 👍

minjeong9919 · 2024-06-22T04:32:58Z

src/app/(auth)/sign-in/page.tsx

 import classNames from 'classnames/bind';
 import { useState } from 'react';
-import { Modal, Button } from '@/components';
+import SignInModal from '../../../components/SignInModal/SignInModal';


@components로 가능한가요?

해당 모달이 들어가는곳이 header밖에 안보이는데 barrel 방식으로 import하면 같은폴더라서 에러나와요

minjeong9919 · 2024-06-22T04:34:10Z

src/app/(auth)/sign-up/_component/SignupForm.tsx

    setValue,
    watch,
  } = useForm({
-    mode: 'onBlur',
+    mode: 'onTouched',


blur 말고 OnTouched로 바꾸신 이유가 있을까용?

사용해보시면 알거에요 피드백이 조금 더 빨라요우

minjeong9919 · 2024-06-22T04:35:26Z

src/app/(auth)/sign-up/_component/SignupForm.tsx

@@ -88,18 +94,21 @@ export default function SignupForm() {

    password: register('password', {
      required: ERROR_MESSAGE.PASSWORD.required,
+      minLength: { value: 8, message: ERROR_MESSAGE.PASSWORD.invalid },


이거 regex안에 포함되어있지 않나요?! 추가적으로 minLength 설정하신 이유가 있으신가요?!?

직접 써보니까 피드백이 안나오는거같아서 그냥 추가해놨어요

minjeong9919 · 2024-06-22T04:38:24Z

src/app/(auth)/sign-up/_component/SignupForm.tsx

                <label htmlFor='check2' className={cn('checkbox-label')}>
+                  <input {...registers.check2} type='checkbox' className={cn('checkbox-input')} id='check2' />


label 밑에 input을 넣는군요! 체크체크👌

안넣고 작업하시려면 htmlFor 값에 id를 맞춰주어야 label 클릭해도 상호작용이 됩니다

src/app/(auth)/sign-up/_component/SignupForm.tsx

minjeong9919 · 2024-06-22T04:40:49Z

src/app/providers.tsx

@@ -40,6 +44,7 @@ export function Providers({ children }: ProvidersProps) {
      <ScrollUpButton headerRef={scrollRef} />
      <div id='modal' />
      <ReactQueryDevtools initialIsOpen={false} />
+      <ToastContainer autoClose={2000} theme='dark' position='top-center' transition={Zoom} />


오옹 provider로 빼는거였군요

정적빌드에러나서 여러가지 시도하다가 실패한 흔적이에요 어디에 두던 상관없읍니다...

https://dev.to/koyablue/how-to-use-react-toastify-with-app-router-447n
나중에 민정님께서 도전...?

minjeong9919 · 2024-06-22T04:42:37Z

src/components/SignInModal/SignInModal.tsx

+import Button from '../Buttons/Button/Button';
+import InputField from '../InputField/InputField';


둘 다 아마 @components 의 index 파일에 잇을 겁니다잇

같은 폴더라서 에러나요 그룹화를 따로하던지 수정해야합니다

ggjiny

고생하셨습니다!!

src/components/Dropdown/Dropdown.module.scss

ggjiny · 2024-06-22T05:15:57Z

src/components/RadioField/RadioField.tsx

        {options.map((option) => (
          <Radio
            ref={ref}
-            key={option}
-            id={option}
-            value={option}
-            checked={selectedValue === option}
+            key={option.value}
+            id={option.value}
+            value={option.value}
+            isChecked={selectedValue === option.value}
            isError={!!errorMessage}


{options.map(([value]) => ( <Radio ref={ref} key={value} id={value} value={value} isChecked={selectedValue === value} isError={!!errorMessage}

이렇게 쓸 수 있을 것 같아요

src/components/parts/Input.module.scss

src/components/parts/Radio.module.scss

src/components/parts/Radio.tsx

Young2un

고생하셨서용,,

src/app/my-info/page.tsx

src/components/Dropdown/Dropdown.module.scss

armd482

수고하셨습니다.

src/components/DatePicker/Calendar.tsx

src/components/parts/Radio.tsx

bokeeeey added 8 commits June 21, 2024 22:40

Refactor: Dropdown CSS 수정

d6d3495

Refactor: header css 수정

b3f2eac

Refactor: header에 로그인 모달 연결 & 마이페이지 리다이렉트 수정

d9f6711

Refactor: RadioInput 수정

3a75a2f

Refactor: 회원가입 페이지 수정

0dd98b1

Refactor: Dropdown maxHeight 추가

60adaad

Feat: GENDER OPTION 상수로 분리

879410f

Chore: import 수정

69dd56e

bokeeeey added 🐞 Fix 버그 수정 🔨 Refactor 코드 리팩토링 labels Jun 21, 2024

bokeeeey requested review from ggjiny, armd482, minjeong9919 and Young2un June 21, 2024 18:46

bokeeeey self-assigned this Jun 21, 2024

bokeeeey linked an issue Jun 21, 2024 that may be closed by this pull request

[Fix] header position & input style 수정 #102

Closed

bokeeeey marked this pull request as ready for review June 21, 2024 18:47

Refactor: Toast 에러 잡으려 했지만 실패,,,

ebe3186

minjeong9919 approved these changes Jun 22, 2024

View reviewed changes

ggjiny approved these changes Jun 22, 2024

View reviewed changes

Young2un approved these changes Jun 22, 2024

View reviewed changes

src/app/my-info/page.tsx Outdated Show resolved Hide resolved

src/components/Dropdown/Dropdown.module.scss Outdated Show resolved Hide resolved

armd482 approved these changes Jun 22, 2024

View reviewed changes

src/components/DatePicker/Calendar.tsx Outdated Show resolved Hide resolved

src/components/parts/Radio.tsx Outdated Show resolved Hide resolved

bokeeeey added 3 commits June 22, 2024 17:44

Feat: header cart icon 클릭 이벤트 추가

d9260c8

Feat: 마이페이지 레이아웃 구성

7f68e89

Fix: style & 사소한 수정

8f93f28

bokeeeey merged commit 419ba8c into develop Jun 22, 2024

bokeeeey deleted the 102-fix-header-position-input-style-수정 branch June 22, 2024 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] header position & input style 수정 #103

[Fix] header position & input style 수정 #103

bokeeeey commented Jun 21, 2024 •

edited

Loading

minjeong9919 left a comment

minjeong9919 Jun 22, 2024

bokeeeey Jun 22, 2024

minjeong9919 Jun 22, 2024

bokeeeey Jun 22, 2024

minjeong9919 Jun 22, 2024

bokeeeey Jun 22, 2024

minjeong9919 Jun 22, 2024

bokeeeey Jun 22, 2024

minjeong9919 Jun 22, 2024

bokeeeey Jun 22, 2024

minjeong9919 Jun 22, 2024

bokeeeey Jun 22, 2024

ggjiny left a comment

ggjiny Jun 22, 2024

Young2un left a comment

armd482 left a comment

		<label htmlFor='check2' className={cn('checkbox-label')}>
		<input {...registers.check2} type='checkbox' className={cn('checkbox-input')} id='check2' />

		import Button from '../Buttons/Button/Button';
		import InputField from '../InputField/InputField';

[Fix] header position & input style 수정 #103

[Fix] header position & input style 수정 #103

Conversation

bokeeeey commented Jun 21, 2024 • edited Loading

🚀 작업 내용

✅ 체크리스트

minjeong9919 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggjiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Young2un left a comment

Choose a reason for hiding this comment

armd482 left a comment

Choose a reason for hiding this comment

bokeeeey commented Jun 21, 2024 •

edited

Loading