Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] interceptor 구현 #177

Merged
merged 35 commits into from
Aug 21, 2024
Merged

[Feat] interceptor 구현 #177

merged 35 commits into from
Aug 21, 2024

Conversation

armd482
Copy link
Contributor

@armd482 armd482 commented Aug 16, 2024

🚀 작업 내용

  • interceptor, 토큰 관리 코드 추가
  • 알림 코드 추가(zustand, persist 관리)

📝 참고 사항

🖼️ 스크린샷

🚨 관련 이슈 (이슈 번호)

✅ 체크리스트

  • Code Review 요청
  • Label 설정
  • PR 제목 규칙에 맞는지 확인

@armd482 armd482 added 📬 API 서버 api 통신 ✨ Component 기능 개발 labels Aug 16, 2024
@armd482 armd482 self-assigned this Aug 16, 2024
Copy link
Contributor

@bokeeeey bokeeeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 LGTM!

Copy link
Contributor

@minjeong9919 minjeong9919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

Comment on lines +151 to +157
<div onClick={(e) => e.stopPropagation()}>
<WriteEditModal
reviewType='customReviewEdit'
onSuccessReview={handleCloseEditModal}
editCustomData={detailData?.data}
/>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 writeEditModal 내에서 e.stopPropagation 처리할까요?

Comment on lines -85 to -90
const token = await getCookie('accessToken');

if (!token) {
return null;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나하나 수정하느라 고생하셨겠군뇨,,,

@armd482 armd482 force-pushed the 140-feat-interceptor-구현 branch from 3f559d0 to 822869e Compare August 20, 2024 08:37
@minjeong9919
Copy link
Contributor

커뮤니티 테스트 완

@armd482 armd482 force-pushed the 140-feat-interceptor-구현 branch from af06d82 to 3bb346b Compare August 21, 2024 11:09
@armd482 armd482 merged commit 455ca45 into develop Aug 21, 2024
@armd482 armd482 deleted the 140-feat-interceptor-구현 branch August 25, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📬 API 서버 api 통신 ✨ Component 기능 개발
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feat] interceptor 구현
3 participants