Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 마이페이지 - 기본 페이지 구현 #81

Merged
merged 34 commits into from
Jun 17, 2024
Merged

[Feat] 마이페이지 - 기본 페이지 구현 #81

merged 34 commits into from
Jun 17, 2024

Conversation

bokeeeey
Copy link
Contributor

@bokeeeey bokeeeey commented Jun 13, 2024 •
edited
Loading

🚀 작업 내용

  • 마이페이지 layout 구현
  • 회원정보 수정 모달 구현

📝 참고 사항

  • 몇가지 컴포넌트 받아서 추가해야하는 부분이 있어요 70%만 완성했읍니다

🖼️ 스크린샷

image
image

🚨 관련 이슈 (이슈 번호)

✅ 체크리스트

  • Code Review 요청
  • Label 설정
  • PR 제목 규칙에 맞는지 확인

@bokeeeey bokeeeey added 📖 Page 페이지 제작 ✨ Component 기능 개발 labels Jun 13, 2024
@bokeeeey bokeeeey self-assigned this Jun 13, 2024
@bokeeeey bokeeeey linked an issue Jun 13, 2024 that may be closed by this pull request
[Feat] 마이페이지 => 기본 페이지 구현 #70
Closed
@bokeeeey bokeeeey marked this pull request as ready for review June 13, 2024 18:18
Young2un
Young2un reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Young2un Young2un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 아시는게 많으신거같아용,,! 고생하셨어용

src/api/profileAPI.ts Outdated Show resolved Hide resolved
src/app/my-info/_components/DeliveryStatus/DeliveryStatus.tsx Show resolved Hide resolved
src/app/my-info/_components/RecentProducts/RecentProducts.module.scss Outdated Show resolved Hide resolved
src/app/my-info/_components/MyInfoEmptyCase/MyInfoEmptyCase.tsx Outdated Show resolved Hide resolved
src/app/my-info/_components/MyInfoEmptyCase/MyInfoEmptyCase.tsx Show resolved Hide resolved
src/app/my-info/_components/UserProfile/EditProfileModal/EditProfileModal.tsx Outdated Show resolved Hide resolved
src/constants/route.ts Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
src/components/Header/HeaderParts/CartButton.tsx Show resolved Hide resolved
src/styles/globals/_fonts.scss Outdated Show resolved Hide resolved
minjeong9919
minjeong9919 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@minjeong9919 minjeong9919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍 인풋 컴포넌트가 원래 퍼펙트했지만 점점 퍼펙트 되어가네요우

src/api/profileAPI.ts Outdated Show resolved Hide resolved
src/api/profileAPI.ts Outdated Show resolved Hide resolved
src/api/profileAPI.ts Outdated Show resolved Hide resolved
src/app/my-info/_components/RecentProducts/RecentProducts.tsx Show resolved Hide resolved
src/app/my-info/page.module.scss Outdated Show resolved Hide resolved
src/types/profileType.ts Outdated Show resolved Hide resolved
src/libs/unFormatPhoneNumber.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatPhoneNumber파일과 하나의 파일로 관리하는 것은 ⭐️로 일까요?

armd482
armd482 approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@armd482 armd482 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 저희 컴포넌트 말고 다른 함수들도 함수 선언식으로 하는 건가요?

next.config.mjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환경 변수 config에 등록 안해도 되지 않나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 안올라갈줄 알았는데 이전 커밋 확인해보시면 올라가더라구요
.local붙혀서 수정하긴 했는데 보험차원에서 작성했읍니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env에 이름을 NEXT_PUBLIC_KEYDEUK_API_BASE_URL라고 등록하면 여기엔 안써도 되는 것 같습니다??

src/components/InputField/InputField.tsx Outdated Show resolved Hide resolved
src/libs/changePhoneNumber.ts Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정규 표현식도 상수화해서 사용하면 더 좋을 것 같습니다

src/libs/formatPhoneNumber.ts Outdated Show resolved Hide resolved
src/app/my-info/_components/UserProfile/EditProfileModal/EditProfileModal.module.scss Show resolved Hide resolved
@bokeeeey
Copy link
Contributor Author

@armd482 함수선언은 전 그냥 이게 편해서 했습니다

@minjeong9919
Copy link
Contributor

@armd482 함수선언은 전 그냥 이게 편해서 했습니다

저희 컴포넌트 외에는 함수 선언 안 사용하기로 했던 것 같아요~!

ggjiny
ggjiny approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@ggjiny ggjiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~

next.config.mjs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env에 이름을 NEXT_PUBLIC_KEYDEUK_API_BASE_URL라고 등록하면 여기엔 안써도 되는 것 같습니다??

src/api/profileAPI.ts Outdated Show resolved Hide resolved
src/app/layout.tsx Outdated Show resolved Hide resolved
src/app/my-info/_components/SNB/SNB.module.scss Outdated Show resolved Hide resolved
src/app/my-info/_components/UserProfile/EditProfileModal/EditProfileModal.module.scss Outdated Show resolved Hide resolved
src/app/my-info/_components/UserProfile/EditProfileModal/EditProfileModal.module.scss Outdated Show resolved Hide resolved
src/app/my-info/_components/UserProfile/EditProfileModal/EditProfileModal.tsx Outdated Show resolved Hide resolved
src/app/my-info/_components/UserProfile/UserProfile.module.scss Outdated Show resolved Hide resolved
src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
src/components/Header/Header.tsx Outdated Show resolved Hide resolved
@bokeeeey bokeeeey merged commit f2ccf17 into develop Jun 17, 2024
@bokeeeey bokeeeey deleted the 70-feat-마이페이지-=-기본-페이지-구현 branch June 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggjiny ggjiny ggjiny approved these changes

@armd482 armd482 armd482 approved these changes

@minjeong9919 minjeong9919 minjeong9919 approved these changes

@Young2un Young2un Young2un approved these changes

Assignees

@bokeeeey bokeeeey

Labels
✨ Component 기능 개발 📖 Page 페이지 제작
Projects
Quad8-front
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 마이페이지 => 기본 페이지 구현
5 participants
@bokeeeey @minjeong9919 @ggjiny @armd482 @Young2un