Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 상품 상세 상단 부분 UI 구현 #89

Merged
merged 27 commits into from
Jun 20, 2024
Merged

[Feat] 상품 상세 상단 부분 UI 구현 #89

merged 27 commits into from
Jun 20, 2024

Conversation

ggjiny
Copy link
Contributor

@ggjiny ggjiny commented Jun 17, 2024 •
edited
Loading

🚀 작업 내용

  • 상품 상세 상단 부분 구현
  • 상품 상세 조회 API 연결
  • LikeButton 삭제(관련 민정님 코드 주석처리)
  • 드롭다운 동작 구현
  • 장바구니 API 연결

📝 참고 사항

  • 버튼과 드롭다운 동작은 아직 구현 전 입니다 -> 완료

🖼️ 스크린샷

image
image

🚨 관련 이슈 (이슈 번호)

✅ 체크리스트

  • Code Review 요청
  • Label 설정
  • PR 제목 규칙에 맞는지 확인

@ggjiny ggjiny added 📖 Page 페이지 제작 ✨ Component 기능 개발 labels Jun 17, 2024
@ggjiny ggjiny self-assigned this Jun 17, 2024
@ggjiny ggjiny linked an issue Jun 17, 2024 that may be closed by this pull request
[Feat] 상품 상세 상단 부분 구현 #75
Closed
armd482
armd482 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@armd482 armd482 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

src/app/(test)/yj/_components/OptionWithButtons.tsx Outdated Show resolved Hide resolved
src/api/productAPI.ts Show resolved Hide resolved
src/app/(test)/yj/_components/OptionWithButtons.tsx Outdated Show resolved Hide resolved
src/app/(test)/yj/_components/ProductDetail.module.scss Outdated Show resolved Hide resolved
src/app/(test)/yj/_components/ProductDetail.module.scss Outdated Show resolved Hide resolved
bokeeeey
bokeeeey approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@bokeeeey bokeeeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

src/api/productAPI.ts Show resolved Hide resolved
src/app/(test)/yj/_components/OptionWithButtons.tsx Outdated Show resolved Hide resolved
src/app/(test)/yj/_components/OptionWithButtons.tsx Outdated Show resolved Hide resolved
src/app/(test)/yj/_components/OptionWithButtons.tsx Outdated Show resolved Hide resolved
src/app/(test)/yj/_components/ProductDetail.tsx Outdated Show resolved Hide resolved
src/app/(test)/yj/_components/Thumbnail.tsx Outdated Show resolved Hide resolved
minjeong9919
minjeong9919 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@minjeong9919 minjeong9919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍 예진님은 항상 엄청난 꼼꼼함이 묻어난 코드인 것 같아용

src/app/(test)/yj/_components/ProductDetail.module.scss Outdated Show resolved Hide resolved
Young2un
Young2un approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@Young2un Young2un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 깔끔하고 가독성이 좋아요 !! 오브젝트메서드 저도 다음에 써봐야겠다 생각 들었어용!!
나중에 쓸거 주석처리 해놓은 것도 굿굿👍👍👍

src/app/shop/[category]/[productId]/_components/Product/Thumbnail.module.scss
width: 100%;
height: auto;
padding-bottom: 1.2rem;
aspect-ratio: 4/3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 이건 무슨 속성인가용??!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 크기 비율을 조정하는거에요!! 이렇게 하면 가로가 줄어들 때 세로도 같이 줄어듭니당당

src/app/shop/[category]/[productId]/_components/Product/ProductDetail.tsx Show resolved Hide resolved
@ggjiny ggjiny added the 📬 API 서버 api 통신 label Jun 19, 2024
bokeeeey
bokeeeey approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@bokeeeey bokeeeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 쓰셨는데용? 다음에 onSuccess랑 onError까지 핸들링해보시면 무난히 사용하실거같아요

src/api/productAPI.ts Outdated Show resolved Hide resolved
src/app/shop/[category]/[productId]/_components/Product/OptionWithButtons.tsx Outdated Show resolved Hide resolved
Young2un
Young2un approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@Young2un Young2un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿이에용! 배워가겠습니당~!

src/app/shop/[category]/[productId]/_components/Product/OptionWithButtons.tsx Show resolved Hide resolved
src/app/shop/[category]/[productId]/_components/Product/ProductDetail.module.scss Outdated Show resolved Hide resolved
@ggjiny ggjiny merged commit c193494 into develop Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devToram devToram devToram left review comments

@armd482 armd482 armd482 approved these changes

@minjeong9919 minjeong9919 minjeong9919 approved these changes

@Young2un Young2un Young2un approved these changes

@bokeeeey bokeeeey bokeeeey approved these changes

Assignees

@ggjiny ggjiny

Labels
📬 API 서버 api 통신 ✨ Component 기능 개발 📖 Page 페이지 제작
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 상품 상세 상단 부분 구현
6 participants
@ggjiny @devToram @armd482 @minjeong9919 @Young2un @bokeeeey