Skip to content

Commit

Permalink
Added Symbols ZEC, JPY, MLN, XBT, XLM for Kraken Market (#37)
Browse files Browse the repository at this point in the history
  • Loading branch information
ashutoshrana171 authored Feb 6, 2024
1 parent c79e876 commit 19d627f
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ private static TestCaseData[] CorrectBrokerageSymbolTestParameters
new TestCaseData(Symbol.Create("ETHUSDT", SecurityType.Crypto, Market.Kraken), "ETHUSDT", false),
new TestCaseData(Symbol.Create("XRPBTC", SecurityType.Crypto, Market.Kraken), "XXRPXXBT", false),
new TestCaseData(Symbol.Create("ETHBTC", SecurityType.Crypto, Market.Kraken), "XETHXXBT", false),
new TestCaseData(Symbol.Create("XLMUSD", SecurityType.Crypto, Market.Kraken), "XXLMZUSD", false),
new TestCaseData(Symbol.Create("ZECBTC", SecurityType.Crypto, Market.Kraken), "XZECXXBT", false),
new TestCaseData(Symbol.Create("ZECEUR", SecurityType.Crypto, Market.Kraken), "XZECZEUR", false),
new TestCaseData(Symbol.Create("ZECUSD", SecurityType.Crypto, Market.Kraken), "XZECZUSD", false),
new TestCaseData(Symbol.Create("ETHJPY", SecurityType.Crypto, Market.Kraken), "XETHZJPY", false),
new TestCaseData(Symbol.Create("LTCBTC", SecurityType.Crypto, Market.Kraken), "XLTCXXBT", false),
new TestCaseData(Symbol.Create("MLNBTC", SecurityType.Crypto, Market.Kraken), "XMLNXXBT", false),
new TestCaseData(Symbol.Create("EURBTC", SecurityType.Crypto, Market.Kraken), "", true), // no such a ticker on kraken
new TestCaseData(Symbol.Create("BTCUSD", SecurityType.Crypto, Market.Binance), "XXBTZUSD", true), // wrong Market
new TestCaseData(Symbol.Create("ETHUSDT", SecurityType.Future, Market.Kraken), "ETHUSDT", true), // wrong SecurityType
Expand All @@ -52,6 +59,13 @@ private static TestCaseData[] CorrectLeanSymbolTestParameters
new TestCaseData("ETHUSDT", Symbol.Create("ETHUSDT", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XXRPXXBT", Symbol.Create("XRPBTC", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XETHXXBT", Symbol.Create("ETHBTC", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XXLMZUSD", Symbol.Create("XLMUSD", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XZECXXBT", Symbol.Create("ZECBTC", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XZECZEUR", Symbol.Create("ZECEUR", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XZECZUSD", Symbol.Create("ZECUSD", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XETHZJPY", Symbol.Create("ETHJPY", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XLTCXXBT", Symbol.Create("LTCBTC", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("XMLNXXBT", Symbol.Create("MLNBTC", SecurityType.Crypto, Market.Kraken), false),
new TestCaseData("", Symbol.Create("EURBTC", SecurityType.Crypto, Market.Kraken), true), // no such a ticker on kraken
};
}
Expand All @@ -68,6 +82,13 @@ private static TestCaseData[] WsSymbolTestParameters
new TestCaseData(Symbol.Create("ETHUSDT", SecurityType.Crypto, Market.Kraken), "ETH/USDT", false),
new TestCaseData(Symbol.Create("XRPBTC", SecurityType.Crypto, Market.Kraken), "XRP/XBT", false),
new TestCaseData(Symbol.Create("ETHBTC", SecurityType.Crypto, Market.Kraken), "ETH/XBT", false),
new TestCaseData(Symbol.Create("XLMUSD", SecurityType.Crypto, Market.Kraken), "XLM/USD", false),
new TestCaseData(Symbol.Create("ZECBTC", SecurityType.Crypto, Market.Kraken), "ZEC/XBT", false),
new TestCaseData(Symbol.Create("ZECEUR", SecurityType.Crypto, Market.Kraken), "ZEC/EUR", false),
new TestCaseData(Symbol.Create("ZECUSD", SecurityType.Crypto, Market.Kraken), "ZEC/USD", false),
new TestCaseData(Symbol.Create("ETHJPY", SecurityType.Crypto, Market.Kraken), "ETH/JPY", false),
new TestCaseData(Symbol.Create("LTCBTC", SecurityType.Crypto, Market.Kraken), "LTC/XBT", false),
new TestCaseData(Symbol.Create("MLNBTC", SecurityType.Crypto, Market.Kraken), "MLN/XBT", false),
};
}
}
Expand Down
6 changes: 6 additions & 0 deletions QuantConnect.KrakenBrokerage/KrakenSymbolMapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,19 @@ public class KrakenSymbolMapper : ISymbolMapper
{"ZGBP", "GBP"},
{"ZAUD", "AUD"},
{"ZCAD", "CAD"},
{"ZJPY", "JPY"},
{"XXBT", "BTC"},
{"XXRP", "XRP"},
{"XLTC", "LTC"},
{"XETH", "ETH"},
{"XETC", "ETC"},
{"XLMN", "MLN"},
{"XREP", "REP"},
{"XXBT", "XBT"},
{"XXMR", "XMR"},
{"XXLM", "XLM"},
{"XZEC", "ZEC"},

};

public KrakenSymbolMapper()
Expand Down

0 comments on commit 19d627f

Please sign in to comment.