Skip to content

Commit

Permalink
Merge pull request #13 from jhonabreul/refactor-normalize-namespaces
Browse files Browse the repository at this point in the history
Normalize namespace to match all other Lean brokerages
  • Loading branch information
jhonabreul authored Feb 29, 2024
2 parents 709fd03 + 08123c8 commit c7a791c
Show file tree
Hide file tree
Showing 28 changed files with 48 additions and 52 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gh-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ jobs:
run: dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.Wolverine.sln

- name: Run Tests
run: dotnet test ./QuantConnect.Wolverine.Tests/bin/Release/QuantConnect.Wolverine.Tests.dll
run: dotnet test ./QuantConnect.Wolverine.Tests/bin/Release/QuantConnect.Brokerages.Wolverine.Tests.dll
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<Copyright>Copyright © 2021</Copyright>
<TestProjectType>UnitTest</TestProjectType>
<OutputPath>bin\$(Configuration)\</OutputPath>
<Product>QuantConnect.Wolverine.Tests</Product>
<AssemblyName>QuantConnect.Wolverine.Tests</AssemblyName>
<RootNamespace>QuantConnect.Wolverine.Tests</RootNamespace>
<AssemblyTitle>QuantConnect.Wolverine.Tests</AssemblyTitle>
<Product>QuantConnect.Brokerages.Wolverine.Tests</Product>
<AssemblyName>QuantConnect.Brokerages.Wolverine.Tests</AssemblyName>
<RootNamespace>QuantConnect.Brokerages.Wolverine.Tests</RootNamespace>
<AssemblyTitle>QuantConnect.Brokerages.Wolverine.Tests</AssemblyTitle>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine.Tests/TestSetup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuantConnect.Tests;

namespace QuantConnect.Wolverine.Tests
namespace QuantConnect.Brokerages.Wolverine.Tests
{
[TestFixture]
public class TestSetup
Expand Down
4 changes: 2 additions & 2 deletions QuantConnect.Wolverine.Tests/Usings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
global using QuantConnect.Util;
global using QuantConnect.Orders;
global using QuantConnect.Packets;
global using QuantConnect.Wolverine.Fix;
global using QuantConnect.Brokerages.Wolverine.Fix;
global using QuantConnect.Logging;
global using QuantConnect.Algorithm;
global using QuantConnect.Interfaces;
global using QuantConnect.Wolverine.Fix.Core;
global using QuantConnect.Brokerages.Wolverine.Fix.Core;
global using QuantConnect.Configuration;
global using QuantConnect.Tests.Brokerages;
global using Log = QuantConnect.Logging.Log;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* limitations under the License.
*/

namespace QuantConnect.Wolverine.Tests
namespace QuantConnect.Brokerages.Wolverine.Tests
{
public class WolverineBrokerageFactoryTests
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuantConnect.Tests;

namespace QuantConnect.Wolverine.Tests
namespace QuantConnect.Brokerages.Wolverine.Tests
{
[TestFixture]
public class WolverineBrokerageSymbolMapperTests
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine.Tests/WolverineBrokerageTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuantConnect.Tests;

namespace QuantConnect.Wolverine.Tests
namespace QuantConnect.Brokerages.Wolverine.Tests
{
[TestFixture]
[Explicit("These tests require a valid WEX configuration.")]
Expand Down
4 changes: 2 additions & 2 deletions QuantConnect.Wolverine/Fix/Core/FixBrokerageController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
*/

using QuantConnect.Orders;
using QuantConnect.Wolverine.Fix.Protocol;
using QuantConnect.Brokerages.Wolverine.Fix.Protocol;
using QuickFix.Fields;
using QuickFix.FIX42;
using System.Collections.Concurrent;

namespace QuantConnect.Wolverine.Fix.Core
namespace QuantConnect.Brokerages.Wolverine.Fix.Core
{
public class FixBrokerageController : IFixBrokerageController
{
Expand Down
4 changes: 2 additions & 2 deletions QuantConnect.Wolverine/Fix/Core/IFixBrokerageController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
*/

using QuantConnect.Orders;
using QuantConnect.Wolverine.Fix.Protocol;
using QuantConnect.Brokerages.Wolverine.Fix.Protocol;
using QuickFix.FIX42;

namespace QuantConnect.Wolverine.Fix.Core
namespace QuantConnect.Brokerages.Wolverine.Fix.Core
{
/// <summary>
/// Controls brokerage related communication between QC and a FIX protocol implementation.
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/Core/ISession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuickFix;

namespace QuantConnect.Wolverine.Fix.Core
namespace QuantConnect.Brokerages.Wolverine.Fix.Core
{
public interface ISession
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/Core/QuickFixSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuickFix;

namespace QuantConnect.Wolverine.Fix.Core
namespace QuantConnect.Brokerages.Wolverine.Fix.Core
{
public class QuickFixSession : ISession
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/FixConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
using QuickFix;
using QuantConnect.Configuration;

namespace QuantConnect.Wolverine.Fix
namespace QuantConnect.Brokerages.Wolverine.Fix
{
public class FixConfiguration
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/FixError.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* limitations under the License.
*/

namespace QuantConnect.Wolverine.Fix
namespace QuantConnect.Brokerages.Wolverine.Fix
{
/// <summary>
/// Class is used to return error message from FIX protocol pipeline
Expand Down
6 changes: 3 additions & 3 deletions QuantConnect.Wolverine/Fix/FixInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
using QuantConnect.Util;
using QuickFix.Transport;
using QuantConnect.Securities;
using QuantConnect.Wolverine.Fix.Protocol;
using QuantConnect.Wolverine.Fix.LogFactory;
using QuantConnect.Brokerages.Wolverine.Fix.Protocol;
using QuantConnect.Brokerages.Wolverine.Fix.LogFactory;

namespace QuantConnect.Wolverine.Fix
namespace QuantConnect.Brokerages.Wolverine.Fix
{
/// <summary>
/// The instance of a single QuickFIX/n configuration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
using QuickFix;
using System.Collections.Concurrent;

namespace QuantConnect.Wolverine.Fix.LogFactory
namespace QuantConnect.Brokerages.Wolverine.Fix.LogFactory
{
public class QuickFixLogFactory : ILogFactory
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/LogFactory/QuickFixLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuickFix;

namespace QuantConnect.Wolverine.Fix.LogFactory
namespace QuantConnect.Brokerages.Wolverine.Fix.LogFactory
{
public class QuickFixLogger : ILog
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuantConnect.Orders;

namespace QuantConnect.Wolverine.Fix.Protocol
namespace QuantConnect.Brokerages.Wolverine.Fix.Protocol
{
public interface IFixOutboundBrokerageHandler
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuickFix;

namespace QuantConnect.Wolverine.Fix.Protocol
namespace QuantConnect.Brokerages.Wolverine.Fix.Protocol
{
/// <summary>
/// Applies protocol specific customizations, and helps direct FIX messages to specific handlers.
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/Utils/MessageUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
using System.Collections.Concurrent;
using System.Reflection;

namespace QuantConnect.Wolverine.Fix.Utils
namespace QuantConnect.Brokerages.Wolverine.Fix.Utils
{
public static class MessageUtils
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/Fix/Utils/Utility.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
using QuickFix.FIX42;
using QF = QuickFix.Fields;

namespace QuantConnect.Wolverine.Fix.Utils
namespace QuantConnect.Brokerages.Wolverine.Fix.Utils
{
public static class Utility
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/IWolverineFixSessionHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using QuickFix;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
public interface IWolverineFixSessionHandler
{
Expand Down
8 changes: 4 additions & 4 deletions QuantConnect.Wolverine/QuantConnect.Wolverine.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
<TargetFramework>net6.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<Product>QuantConnect.Wolverine</Product>
<AssemblyName>QuantConnect.Wolverine</AssemblyName>
<RootNamespace>QuantConnect.Wolverine</RootNamespace>
<AssemblyTitle>QuantConnect.Wolverine</AssemblyTitle>
<Product>QuantConnect.Brokerages.Wolverine</Product>
<AssemblyName>QuantConnect.Brokerages.Wolverine</AssemblyName>
<RootNamespace>QuantConnect.Brokerages.Wolverine</RootNamespace>
<AssemblyTitle>QuantConnect.Brokerages.Wolverine</AssemblyTitle>
<OutputType>Library</OutputType>
<OutputPath>bin\$(Configuration)\</OutputPath>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
Expand Down
10 changes: 4 additions & 6 deletions QuantConnect.Wolverine/WolverineBrokerage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@
using QuantConnect.Packets;
using QuantConnect.Interfaces;
using QuantConnect.Securities;
using QuantConnect.Brokerages;
using QuantConnect.Wolverine.Fix;
using QuantConnect.Wolverine.Fix.Core;
using QuantConnect.Brokerages.Wolverine.Fix;
using QuantConnect.Brokerages.Wolverine.Fix.Core;
using QuickFix.FIX42;
using QuantConnect.Logging;
using QuantConnect.Orders.Fees;
using QuantConnect.Wolverine.Fix.Utils;
using QuantConnect.Configuration;
using QuantConnect.Brokerages.Wolverine.Fix.Utils;
using QuantConnect.Api;
using System.Net.NetworkInformation;
using System.Net;
Expand All @@ -36,7 +34,7 @@
using Newtonsoft.Json.Linq;
using QuickFix.Fields;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
[BrokerageFactory(typeof(WolverineBrokerageFactory))]
public class WolverineBrokerage : Brokerage
Expand Down
5 changes: 2 additions & 3 deletions QuantConnect.Wolverine/WolverineBrokerageFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@

using QuantConnect.Util;
using QuantConnect.Packets;
using QuantConnect.Brokerages;
using QuantConnect.Interfaces;
using QuantConnect.Securities;
using QuantConnect.Configuration;
using QuantConnect.Wolverine.Fix;
using QuantConnect.Brokerages.Wolverine.Fix;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
/// <summary>
/// Provides a Wolverine Brokerage implementation of BrokerageFactory
Expand Down
6 changes: 3 additions & 3 deletions QuantConnect.Wolverine/WolverineFixProtocolDirector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
*/

using QuantConnect.Securities;
using QuantConnect.Wolverine.Fix.Core;
using QuantConnect.Wolverine.Fix.Protocol;
using QuantConnect.Brokerages.Wolverine.Fix.Core;
using QuantConnect.Brokerages.Wolverine.Fix.Protocol;
using QuickFix;
using QuickFix.Fields;
using QuickFix.FIX42;
using System.Collections.Concurrent;
using Message = QuickFix.Message;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
public class WolverineFixProtocolDirector : IFixProtocolDirector
{
Expand Down
2 changes: 1 addition & 1 deletion QuantConnect.Wolverine/WolverineOrderId.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

using System.Globalization;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
public static class WolverineOrderId
{
Expand Down
8 changes: 4 additions & 4 deletions QuantConnect.Wolverine/WolverineOrderRoutingSessionHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
using QuantConnect.Securities;
using QuantConnect.Securities.Equity;
using QuantConnect.Util;
using QuantConnect.Wolverine.Fix.Core;
using QuantConnect.Wolverine.Fix.Protocol;
using QuantConnect.Wolverine.Fix.Utils;
using QuantConnect.Brokerages.Wolverine.Fix.Core;
using QuantConnect.Brokerages.Wolverine.Fix.Protocol;
using QuantConnect.Brokerages.Wolverine.Fix.Utils;
using QuickFix;
using QuickFix.Fields;
using QuickFix.FIX42;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
public class WolverineOrderRoutingSessionHandler : MessageCracker, IWolverineFixSessionHandler, IFixOutboundBrokerageHandler
{
Expand Down
3 changes: 1 addition & 2 deletions QuantConnect.Wolverine/WolverineSymbolMapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@
* limitations under the License.
*/

using QuantConnect.Brokerages;
using QuantConnect.Interfaces;
using QuantConnect.Data.Auxiliary;

namespace QuantConnect.Wolverine
namespace QuantConnect.Brokerages.Wolverine
{
public class WolverineSymbolMapper : ISymbolMapper
{
Expand Down

0 comments on commit c7a791c

Please sign in to comment.