Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: update njit to jit #182

Merged
merged 2 commits into from
May 21, 2024
Merged

MAINT: update njit to jit #182

merged 2 commits into from
May 21, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented May 9, 2024 •
edited
Loading

This PR updates njit to jit now that numba>=0.59 is installed

QuantEcon/meta#112

@netlify Netlify
Copy link

netlify bot commented May 9, 2024 •
edited
Loading

✅ Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit 0f5e9d4
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/6641cc9695f45800079bfd02
😎 Deploy Preview https://deploy-preview-182--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

🚀 Deployed on https://6641d4c4683dc48fbce76555--incomparable-parfait-2417f8.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 06:07 Inactive
@mmcky mmcky requested a review from kp992 May 13, 2024 02:47
kp992
kp992 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@kp992 kp992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks @mmcky

@mmcky
Copy link
Contributor Author

mmcky commented May 13, 2024

@kp992 this should be numba rather than numpy right?

Screenshot 2024-05-13 at 3 32 05 PM

@kp992
Copy link
Contributor

kp992 commented May 13, 2024 •
edited
Loading

You're right @mmcky. Nice catch. thanks!

@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 08:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 08:52 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 14, 2024

thanks @kp992.

@jstac this is ready but will wait as I know you're using jax material at the moment.

@mmcky
Copy link
Contributor Author

mmcky commented May 21, 2024

@jstac I will merge this now.

@mmcky mmcky merged commit eca8220 into main May 21, 2024
9 checks passed
@mmcky mmcky deleted the update-jit branch May 21, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp992 kp992 kp992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmcky @kp992