Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmcky this PR should update the JS dependencies to webpack5. I haven't visually tested this, only that it compiles, so it would be good if you could give this a once over on an existing site that uses the theme.
The main changes were:
file-loader
withmini-css-extract-plugin
@import
with@use
(https://sass-lang.com/documentation/at-rules/import/)Most of these are in sphinx-book-theme, but I see from this PR that I now have some additional work to do!
There's a chance I've made a mistake here, given that I haven't compared the outputs to an existing deployment; if you'd be able to do that, would be much obliged.