Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: upgrade to webpack5 #265

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Oct 24, 2024

@mmcky this PR should update the JS dependencies to webpack5. I haven't visually tested this, only that it compiles, so it would be good if you could give this a once over on an existing site that uses the theme.

The main changes were:

Most of these are in sphinx-book-theme, but I see from this PR that I now have some additional work to do!

There's a chance I've made a mistake here, given that I haven't compared the outputs to an existing deployment; if you'd be able to do that, would be much obliged.

@mmcky
Copy link
Contributor

mmcky commented Oct 25, 2024

thanks @agoose77 i will dive in and take a look.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@aeebe8d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage        ?   73.18%           
=======================================
  Files           ?        2           
  Lines           ?      261           
  Branches        ?        0           
=======================================
  Hits            ?      191           
  Misses          ?       70           
  Partials        ?        0           
Flag Coverage Δ
pytests 73.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmcky
Copy link
Contributor

mmcky commented Oct 25, 2024

@agoose77 I fixed up the pre-commit but not sure why they haven't flowed through to this PR.

@mmcky mmcky mentioned this pull request Oct 25, 2024
@mmcky
Copy link
Contributor

mmcky commented Oct 25, 2024

thanks @agoose77 -- really appreciate the help here.

@mmcky mmcky merged commit 3d0b162 into QuantEcon:main Oct 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants