Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionalities to manipulate content #25

Merged
merged 24 commits into from
Nov 28, 2024
Merged

Add functionalities to manipulate content #25

merged 24 commits into from
Nov 28, 2024

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Nov 21, 2024 •
edited
Loading

Added backend implementation and connection to frontend contents manager for the following functionalities:

  • create new object
  • save existing object with new contents
  • rename object
  • copy object
  • delete object
  • check existence of object within drive
  • count appearances of object within drive.

For the saving and creation functionalities, a formatting of the content was also needed, depending on its format.

@DenisaCG DenisaCG added the enhancement New feature or request label Nov 21, 2024
@DenisaCG DenisaCG self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

Binder 👈 Launch a Binder on branch DenisaCG/jupyter-drives/manipulateContents

DenisaCG and others added 19 commits November 25, 2024 14:08
@DenisaCG
Merge branch 'main' into manipulateContents
4eb0d37
@DenisaCG
remove unused import
547ec44
@DenisaCG
iterate on saving functionality
233ceac
@DenisaCG
update docstrings
bd1c598
@DenisaCG
add logic for object creation
d02f167
@DenisaCG
add delete functionality in backend and connect to frontend content m…
f13f307 
…anager
@DenisaCG
fix sub directory listing
9784010
@DenisaCG
format path in backend when listing
2774654
@DenisaCG
add backend functionality to check if object exists in drive and coun…
ef20987 
…t no. of appearances
@DenisaCG
add rename functionaltity in backend and frontend content manager
ff3426e
@DenisaCG
add logic to copy object in backend and frontend content manager
ea27266
@DenisaCG
update docstrings
cea5cc9
@DenisaCG
iterate on saving functionality to format body
103a73c
@DenisaCG
check if operations are done outside of a drive
cf31d43
@DenisaCG
remove log of mounted error
a4e5350
@DenisaCG
wrap deleting object in try and catch block
56ef541
@DenisaCG
refactor code to use helping functions
76516be
@DenisaCG
iterate on check object functionality
d7562eb
@DenisaCG
remove dev comments
dfafbf5
afshin
afshin reviewed Nov 28, 2024
View reviewed changes
jupyter_drives/manager.py Outdated Show resolved Hide resolved
afshin
afshin reviewed Nov 28, 2024
View reviewed changes
jupyter_drives/manager.py Outdated Show resolved Hide resolved
afshin
afshin reviewed Nov 28, 2024
View reviewed changes
jupyter_drives/manager.py Outdated Show resolved Hide resolved
afshin
afshin reviewed Nov 28, 2024
View reviewed changes
jupyter_drives/manager.py Outdated Show resolved Hide resolved
afshin
afshin reviewed Nov 28, 2024
View reviewed changes
jupyter_drives/manager.py Outdated Show resolved Hide resolved
afshin
afshin reviewed Nov 28, 2024
View reviewed changes
jupyter_drives/manager.py Outdated Show resolved Hide resolved
@DenisaCG @afshin
Update docstrings and variable names
ed8fa37 
Co-authored-by: Afshin Taylor Darian <[email protected]>
afshin
afshin approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's merge this when you are ready so that we can get more users on it for testing. Thanks @DenisaCG!

@DenisaCG
Copy link
Member Author

Great, I'll go ahead and merge it. Thanks for the review!

@DenisaCG DenisaCG merged commit c700461 into QuantStack:main Nov 28, 2024
3 of 4 checks passed
@DenisaCG DenisaCG deleted the manipulateContents branch November 28, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afshin afshin afshin approved these changes

Assignees

@DenisaCG DenisaCG

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisaCG @afshin