Provide s3 driver with session token #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For S3 Driver to work it needs all three, access key, secret key and session token
|
|
bhadrip
reviewed
Dec 19, 2024
| @@ -107,7 +107,7 @@ async def list_drives(self): | |||
| if self._config.access_key_id and self._config.secret_access_key: | |||
| if self._config.provider == "s3": | |||
| S3Drive = get_driver(Provider.S3) | |||
| drives = [S3Drive(self._config.access_key_id, self._config.secret_access_key)] | |||
| drives = [S3Drive(self._config.access_key_id, self._config.secret_access_key, True, None, None, None, self._config.session_token)] | |||
There was a problem hiding this comment.
in case of an iam user there will be no session_token, this should still work because it will be none.
Can you test it by configuring with an iam user ?
There was a problem hiding this comment.
Good point. I have tested this locally, and it works in the case of using only an access_key and secret_access_key, so with the session_token set to none.
DenisaCG
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks for opening this @gogakoreli! I will merge this and make a release, but please feel free to open an issue if the auth problem persists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For S3 Driver to work it needs all three, access key, secret key and session token
libcloud S3StorageDriver constructor accepts following:
def __init__(self,key,secret=None,secure=True,host=None,port=None,region=None,token=None,**kwargs)See more: https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/s3.py#L1231