Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Binder configuration #86

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Fix Binder configuration #86

merged 12 commits into from
Aug 14, 2024

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Aug 13, 2024 •
edited
Loading

Fix Binder configuration and remove patches mention, as it's not needed after the v4 migration. Also upgrade pinned version of jupyterlab_widgets package.

@DenisaCG DenisaCG self-assigned this Aug 13, 2024
@DenisaCG DenisaCG added the bug Something isn't working label Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch QuantStack/jupyterlab-blockly/fixBinder

@DenisaCG
Copy link
Member Author

Currently, for the Binder build to succeed, the async_generator and certipy packages, which are sub-dependencies of the main packages we use, need to be specified inside the environment.yml file.

Merging this as the Binder deployment works now. Will open up future PRs for improving the build, if another solution comes up.

@DenisaCG DenisaCG merged commit 15ffb61 into main Aug 14, 2024
6 checks passed
@DenisaCG DenisaCG deleted the fixBinder branch August 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DenisaCG DenisaCG

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DenisaCG