Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argmax and argmin #84

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix argmax and argmin #84

merged 2 commits into from
Oct 25, 2024

Conversation

adityagoel4512
Copy link
Member

Previously, argmax and argmin inserted unnecessary casts since the cast_return flag was True. This fixes this; an example can be seen in the documentation update.

It also makes argmin actually argmin.

cbourjau
cbourjau approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@cbourjau cbourjau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to make a release today.

adityagoel4512
adityagoel4512 commented Oct 25, 2024
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@adityagoel4512 adityagoel4512 merged commit 9fc8a2c into main Oct 25, 2024
16 checks passed
@adityagoel4512 adityagoel4512 deleted the fix-argmax branch October 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbourjau cbourjau cbourjau approved these changes

@neNasko1 neNasko1 Awaiting requested review from neNasko1 neNasko1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityagoel4512 @cbourjau