-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haah's cubic code using abelian group ℤ₃ˣ³ via Hecke's Group Algebra #388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 83.00% 83.02% +0.01%
==========================================
Files 71 71
Lines 4560 4565 +5
==========================================
+ Hits 3785 3790 +5
Misses 775 775 ☔ View full report in Codecov by Sentry. |
I think this is ready for review, @Krastanov. Thanks! Brief context: For GB codes , In Haah cubic code case, the total order is Edit: For large values of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great addition, thank you! I left in a few comments.
|
||
julia> code_n(c), code_k(c) | ||
(432, 8) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also: bicycle_codes, generalized_bicycle_codes
Co-authored-by: Stefan Krastanov <[email protected]>
Co-authored-by: Stefan Krastanov <[email protected]>
The CI is failing on master due to this: QuantumClifford.jl/ext/QuantumCliffordHeckeExt/lifted_product.jl Lines 253 to 256 in 45e9f4d
This was fixed with the the see also. Edit: It seems that theCI is not failing due to the extra spaces, I thought it would cause error when checking docstring. |
that fix is still nice to have! I think it is failing because there are still a few spots with the old capitalization of the name of the code |
marking as draft to make it easier for me to track what needs review |
The PR is ready for review. Thank you! It was indeed the old capitalization in some places that was causing the CI errors. |
This PR aims to implement Haah's cubic code, a cousin of Generalized Bicycle code as mentioned in https://errorcorrectionzoo.org/c/generalized_bicycle.