Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haah's cubic code using abelian group ℤ₃ˣ³ via Hecke's Group Algebra #388

Merged
merged 9 commits into from
Nov 5, 2024

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 10, 2024

This PR aims to implement Haah's cubic code, a cousin of Generalized Bicycle code as mentioned in https://errorcorrectionzoo.org/c/generalized_bicycle.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (45e9f4d) to head (c96731f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   83.00%   83.02%   +0.01%     
==========================================
  Files          71       71              
  Lines        4560     4565       +5     
==========================================
+ Hits         3785     3790       +5     
  Misses        775      775              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz Fe-r-oz marked this pull request as draft October 11, 2024 04:45
@Fe-r-oz Fe-r-oz marked this pull request as ready for review October 11, 2024 09:11
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 11, 2024

I think this is ready for review, @Krastanov. Thanks!

Brief context: For GB codes , n%l+1 is used for GroupAlgebra (GA) indexing to indicate the cyclic nature for single cyclic group. This is same as doing n%dim(GA)+1. This works as here, we have a single cyclic group of order l, so total order is l which can be acquired using dim(GA).

In Haah cubic code case, the total order is , hence using n%dim(GA)+1 is appropriate since dim(GA) would give because here, direct product of three cyclic groups ( total order = lxlxl) is the requirement. Also, The CI errors are unrelated to this PR.

Edit:

For large values of l, there are some crashes due to huge cubic lattice, GA with sparse representation is being worked on by Tommy here: thofma/Hecke.jl#1655. I will add this functionality once available.

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great addition, thank you! I left in a few comments.

ext/QuantumCliffordHeckeExt/lifted_product.jl Outdated Show resolved Hide resolved

julia> code_n(c), code_k(c)
(432, 8)
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also: bicycle_codes, generalized_bicycle_codes

ext/QuantumCliffordHeckeExt/lifted_product.jl Outdated Show resolved Hide resolved
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Nov 5, 2024

The CI is failing on master due to this:

julia> B = 𝜋^8 + 𝜋^14 + 𝜋^47;
(108, 12)

This was fixed with the the see also.

Edit: It seems that theCI is not failing due to the extra spaces, I thought it would cause error when checking docstring.

@Krastanov
Copy link
Member

The CI is failing on master due to this:

julia> B = 𝜋^8 + 𝜋^14 + 𝜋^47;
(108, 12)

This was fixed with the the see also.

Edit: It seems that theCI is not failing due to the extra spaces, I thought it would cause error when checking docstring.

that fix is still nice to have!

I think it is failing because there are still a few spots with the old capitalization of the name of the code

@Krastanov
Copy link
Member

marking as draft to make it easier for me to track what needs review

@Krastanov Krastanov marked this pull request as draft November 5, 2024 15:25
@Fe-r-oz Fe-r-oz marked this pull request as ready for review November 5, 2024 16:29
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Nov 5, 2024

The PR is ready for review. Thank you!

It was indeed the old capitalization in some places that was causing the CI errors.

@Krastanov Krastanov merged commit ce1dc02 into QuantumSavory:master Nov 5, 2024
15 of 18 checks passed
@Fe-r-oz Fe-r-oz deleted the cubic branch November 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants