now able to remove user feedback after given #183
Conversation
|
suggestion: the backend doesn't support an |
| const currentFeedback = positive ? UserFeedback.Positive : UserFeedback.Negative; | ||
|
|
||
| // Determine if we're toggling the current selection off | ||
| const newFeedback = wasHelpful === currentFeedback ? undefined : currentFeedback; |
There was a problem hiding this comment.
Would we prefer setting this to undefined or null ?
There was a problem hiding this comment.
whatever gets decided here can cascade into each of my comments
| @@ -0,0 +1,4 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
polish: should remove this from the PR. Don't think we need a yarn.lock in our scripts directory
| const token = await AuthHelper.getSKaaSAccessToken(instance, inProgress); | ||
|
|
||
| chatService | ||
| .rateMessageAync(selectedId, messageId, positive, token) | ||
| .rateMessageAync(selectedId, messageId, newFeedback === UserFeedback.Positive, token) |
There was a problem hiding this comment.
issue: newFeedback === UserFeedback.Positive evaluates to either true or false. We are going to need to pass undefined here if we want to remove a rating.
There was a problem hiding this comment.
on testing I see that the frontend does update to allow you to remove a "like" or "dislike" but, the payload going to the backend is still either true or false
| const currentFeedback = positive ? UserFeedback.Positive : UserFeedback.Negative; | ||
|
|
||
| // Determine if we're toggling the current selection off | ||
| const newFeedback = wasHelpful === currentFeedback ? undefined : currentFeedback; |
There was a problem hiding this comment.
whatever gets decided here can cascade into each of my comments
Motivation and Context
previously users were unable to remove a like reaction or dislike reaction after providing feedback. now users can add or remove feedback freely.
Description
now able to like, dislike and deselect like or dislike.
Contribution Checklist
checklist complete.