Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added indexname to the toggle request interface #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sam0044
Copy link

@sam0044 sam0044 commented Nov 18, 2024

Currently, there is a bug in the app where if you try to toggle off/on a specialization, the fields Document Count, Strictness, Past messages included and MaxTokenResponse revert back to default. The reason this is happening is because when we toggle the specialization, qSpecializationmutate only has the isActive field set and everything else is null. Because of that when we create the response, since the index name is null, the aforementioned fields are set to null because these fields should not be set without an index. This behavior is somewhat expected because we have a 'None' field in index name because of general being a specialization. So I am passing the index name in the Toggle request interface to distinguish between index being updated and just a specialization toggle.

Contribution Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant