Add support for using artifacts from another Job #185
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 78.74% 78.65% -0.10%
==========================================
Files 47 47
Lines 5388 5412 +24
==========================================
+ Hits 4243 4257 +14
- Misses 1145 1155 +10 ☔ View full report in Codecov by Sentry. |
Our usecase is for cross-compiling Windows tools
| @@ -859,3 +859,34 @@ For the `fetch` stage, the Qubes executor with disposable template `qubes-builde | |||
| For the `build` stage of `vm-fc42`, the Podman executor with container image `fedoraimg` will be used. | |||
| For the `sign` stage, the Qubes executor with disposable template `signing-access-dvm` will be used for both `vm-fc42` and `vm-jammy` | |||
| For the `prep` stage of `vm-jammy`, the Local executor with base directory `/some/path` will be used. | |||
|
|
|||
| ### Cross-compile Build | |||
There was a problem hiding this comment.
Technically, cross-compile is something else, like building ARM binaries on X86. Better use different term, like cross-distribution dependencies
|
|
||
| ```yaml | ||
| components: | ||
| - installer-qubes-os: |
There was a problem hiding this comment.
installer-qubes-os-windows-tools? (and below too)
| if ( | ||
| isinstance(stage, dict) | ||
| and next(iter(stage)) == stage_name | ||
| and isinstance(stage[stage_name], dict) |
There was a problem hiding this comment.
At least some of this not matching should show a warning or even error. Otherwise it will be hard to find why it doesn't work if you make a typo (like extra - making it a list instead of dict).
| if all( | ||
| [ | ||
| need.get("component", None), | ||
| need.get("distribution", None), | ||
| need.get("stage", None), | ||
| need.get("build", None), | ||
| ] |
There was a problem hiding this comment.
and same here - if some part is missing, at least log a warning why it's ignored
| copy_in.append( | ||
| (artifact, self.executor.get_dependencies_dir()) | ||
| ) |
There was a problem hiding this comment.
should they all be copied together, or maybe better in separate subdirs? what if file names conflict (for example you declare QWT use vm-win10 and vm-win11 if that would exist)?
Our usecase is for cross-compiling Windows tools