SystemD dropins for minimal sys-net and sys-usb #540
Conversation
|
packaging need an update, both RPM and DEB. See CI logs, for example: |
|
PipelineRetry |
Guiiix
force-pushed
the
main
branch
4 times, most recently
from
b66e7fa to
20f59e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
=======================================
Coverage 70.14% 70.14%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 329 329
Misses 140 140 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021202-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025020404-4.3&flavor=update
Failed tests51 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/127852#dependencies 30 fixed
Unstable tests52 tests
|
|
Pipewire drop-in needs a different name: |
|
Without polkit(?), the right click nm-applet checkboxes ("enable networking", "enable wifi") don't work... |
|
@marmarek this is a mistake. Polkit should be disabled only for minimal sys-usb. Same for Bluetooth. |
Guiiix
force-pushed
the
main
branch
2 times, most recently
from
ea3a43f to
f4b3d19
Compare
|
I've tested it a bit on Novacustom V56 laptop, and with sys-net set to 300MB wifi quite often crashes ( |
| ConditionPathExists=/var/run/qubes-service/minimal-netvm | ||
| ConditionPathExists=/var/run/qubes/this-is-netvm |
There was a problem hiding this comment.
What is the intended effect? Right now it enables it when both conditions are true - so, if it's netvm and the minimal-netvm service is enabled. If you meant to automatically enable it in netvm but also in potentially other if requested, then it should have | prefix. But otherwise, I'd prefer a single condition - either just "minimal-netvm" service, or automatic in an netvm.
There was a problem hiding this comment.
This would ensure that minimal-netvm has not been activated on anything else than the sys-net VM but maybe this is irrelevant
|
And please announce availability of |
|
I can confirm that now sys-net with 325MB no longer runs into driver failures due to too little memory :) Wifi automatically re-connects after suspend etc. |
I've been running my sys-net with 300MB for a couple of days and it works too. NM applet is a bit slow but internet connection is stable and I don't see any failure in logs 🙂 |
|
Uhm, sys-net just got too aggressive OOM killer: https://openqa.qubes-os.org/tests/129158: That's during VM startup, with 300MB.
|
|
I updated my net-vm to r4.3-testing and indeed, new services are present. I tried to disable |
typo: see journalctl, maybe it will tell you why it ignored the setting |
|
Oops, sorry for the typo. |
|
When masking the service:
When masking the socket or both
|
|
|
|
Can you please document this feature in https://github.com/QubesOS/qubes-core-admin-client/blob/main/doc/manpages/qvm-service.rst |
|
Got an error about conntrack tables full today with 300MB RAM... |
|
Hm, I guess the default size is chosen based on the memory mount. But it should be configurable. But still, even if we increase the limit, the question is whether there is enough RAM to store it. |
|
Yes I guess this is configurable but it might be hard to find a suitable value not too high as we don't have enough memory and not too low as we can have a lot of connections when running multiple qubes with network access. On my sys-net (R4.3-current-testing repos, 325MB RAM) , I have the same value for both variables: 2048. |
|
So, it's not too different from my value, yet I haven't run into such issues. Is it possible that some of your applications opens more than usual connections? You can also list what is in the conntrack table with the |
Some unnecessary services are running on sys-net and sys-usb which consumes RAM for nothing. SystemD dropins are added to automatically disable identified unecessary services by enabling minimal-netvm or minimal-usbvm service on the sys-vms with qvm-service.