Clear CLIENT_SSL in MySQL Handshake packet
#1227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
pdelewski
The TcpPassthroughMysqlProcessor does not yet support SSL, so when using a MySQL client you had to explicitly disable SSL on the client side or disable it on the MySQL server. This change rewrites the initial Handshake packet sent by the MySQL server to inform the client that the server doesn't support SSL. After this change you can connect to MySQL via Quesma without having to manually disable SSL on the client side: ``` mysql -h localhost -P 13306 -u root -p ``` instead of ``` mysql --skip-ssl -h localhost -P 13306 -u root -p ```
avelanarius
force-pushed
the
clear-client-ssl
branch
from
e1aa4a3 to
e0399ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TcpPassthroughMysqlProcessordoes not yet support SSL, so when using a MySQL client you had to explicitly disable SSL on the client side or disable it on the MySQL server.This change rewrites the initial
Handshakepacket sent by the MySQL server to inform the client that the server doesn't support SSL. After this change you can connect to MySQL via Quesma without having to manually disable SSL on the client side:instead of