Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose transport mode #109

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Expose transport mode #109

merged 4 commits into from
Feb 22, 2024

Conversation

RichLogan
Copy link
Contributor

@RichLogan RichLogan commented Feb 16, 2024 •
edited
Loading

Expose TransportMode in client facing APIs, rather than opaque reliable bool.

@RichLogan RichLogan requested a review from TimEvens February 16, 2024 14:06
TimEvens
TimEvens requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@TimEvens TimEvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but tests need to be updated to use reliable. Main branch has this, but it's a bool instead of the transport mode.

I did merge main into your branch because your branch had an old libquicr that would have caused issues if merged.

@TimEvens
Copy link
Contributor

Tests are failing because of the changes that were merged from main. Minor updates needed.

@RichLogan RichLogan requested a review from TimEvens February 21, 2024 09:31
TimEvens
TimEvens approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@TimEvens TimEvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichLogan RichLogan merged commit 93e29d6 into main Feb 22, 2024
2 checks passed
@RichLogan RichLogan deleted the expose-transport-mode branch February 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimEvens TimEvens TimEvens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RichLogan @TimEvens