Add stopguard on registering dynamic registries

No, you cannot use the `minecraft` namespace and blow up the world
QuiltMC · Aug 1, 2023 · c63c489 · c63c489
1 parent 995fb0d
commit c63c489
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/...registry/src/main/java/org/quiltmc/qsl/registry/impl/dynamic/DynamicMetaRegistryImpl.java b/...registry/src/main/java/org/quiltmc/qsl/registry/impl/dynamic/DynamicMetaRegistryImpl.java
@@ -45,7 +45,12 @@ public static boolean isModdedRegistryId(Identifier id) {
 	}
 
 	public static <E> void register(RegistryKey<? extends Registry<E>> ref, Codec<E> entryCodec, DynamicRegistryFlag... flags) {
+		if (ref.getValue().getNamespace().equals(Identifier.DEFAULT_NAMESPACE)) {
+			throw new IllegalStateException("The '" + ref.getValue() + "' dynamic registry cannot have 'minecraft' as its identifier's namespace!");
+		}
+
 		if (frozen) throw new IllegalStateException("Registry is already frozen");
+
 		MODDED_REGISTRY_IDS.add(ref.getValue());
 		RegistryLoader.WORLDGEN_REGISTRIES.add(new RegistryLoader.DecodingData<>(ref, entryCodec));
 		for (DynamicRegistryFlag flag : flags) {