-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Renderer API #230
Draft
williambl
wants to merge
7
commits into
QuiltMC:1.19
Choose a base branch
from
williambl:debug-renderers
base: 1.19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Debug Renderer API #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGlitch76
reviewed
Dec 8, 2022
...ary/misc/debug_renderers/src/main/java/org/quiltmc/qsl/debug_renderers/api/DebugFeature.java
Outdated
Show resolved
Hide resolved
Other than re-implementing some missing MC methods, this is now fully functional. |
EnnuiL
added
t: new api
This adds a new API.
s: wip
This pull request is being worked on.
library: misc
Related to the misc library.
labels
Apr 18, 2023
What is the state of this? |
Definitely stalled, but I was looking into it recently and it seems fairly interesting and not too bad to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
library: misc
Related to the misc library.
s: wip
This pull request is being worked on.
t: new api
This adds a new API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API for Debug Renderers (
DebugRenderer
)Motivation
Vanilla provides a few Debug Renderers, ~all of which are disabled:
The
DebugRenderer
class provides various utility methods, and custom Debug Renderers can be created by implementingDebugRenderer.Renderer
.I've been using this occasionally in fabric mods, just by bridging the
SimpleDebugRenderer
to aWorldRenderEvents.Last
and then conditionally registering that depending on a public static final boolean. This isn't ideal. In addition, turning on the vanilla Debug Renderers has to be done either with mixins or manually running them in a render event.Many vanilla Debug Renderers require extra data to be sent by the server: these are sent through custom payload packets (see the IDs in
CustomPayloadS2CPacket
which start withminecraft:debug/
). These are sent in various static methods inDebugInfoSender
. However, most of these methods have their contents stripped out.Content
Therefore I am making a Debug Renderer API, which adds the following:
DebugFeature
class, with methods:DebugFeature
. (DebugFeature myDebugFeature = DebugFeatureRegistry.register(new Identifier("my_mod:test"), true)
)DebugRendererRegistry.register(myDebugFeature, MyDebugRenderer::new)
)/debug enable x:x
, and on client with a client command/debug_client enable x:x
DebugInfoSender
, checking that the corresponding Debug Feature is active on server and only sending the packets to clients with it also active