Add missing icon to data callback library #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnnuiL
added
library: core
EnnuiL
suggested changes
Jul 27, 2023
LostLuma
force-pushed
the
add-missing-data-callback-icon
branch
from
c3f95db
to
c4f01bb
Compare
|
Painful. I could not get it to build locally so I just decided to make the PR w/o testing 😴 |
EnnuiL
approved these changes
Jul 28, 2023
EnnuiL
added
s: tested
cocona20xx
pushed a commit
to cocona20xx/quilt-standard-libraries
that referenced
this pull request
Aug 2, 2023
cocona20xx
pushed a commit
to cocona20xx/quilt-standard-libraries
that referenced
this pull request
Sep 28, 2023
EnnuiL
added a commit
that referenced
this pull request
Oct 1, 2023
* Implement Dynamic Registry Flags. - Currently, only one flag, `OPTIONAL`, exists. - Modified DynamicRegistrySyncMixin in order to implement these flags. Due to the Redirect mixin header used to implement the flag filtering being taken directly from FAPI, the header of DynamicRegistrySyncMixin was changed to mention FabricMC copyright, in accordance with QSL contribution rules in CONTRIBUTING.md * Implement Dynamic Registry Flags p2 - Modify DynamicRegistryFlagManager to use Identifiers over RegistryKeys internally, in order to avoid generic-related jank. - Fix mixin ported from FAPI by correcting method target string to use Quilt Mappings. - Implement very basic tests. * Expanded upon OPTIONAL flag javadocs to elaborate use-case * Expanded further on OPTIONAL javadocs * Implemented some changes suggested by Pyrofab - Added protected helper method DynamicMetaRegistryImpl#isFrozen for use in DynamicRegistryFlagManager - Added DynamicMetaRegistryImpl#LOGGER with the name "quilt_dynamic_registries" as a logger for catching exceptions related to the setting of flags - Removed the ability to disable dynamic registry flags, changed the signature of the related flag-enabling methods from enableFlag -> setFlag (on both DynamicRegistryFlag and DynamicRegistryFlagManager) - DynamicRegistryFlagManager#setFlag now throws an IllegalStateException if a mod attempts to enable a flag when dynamic registries are frozen. This is caught and printed to the logger mentioned prior in DynamicRegistryFlag calls - Added varargs for setting DynamicRegistryFlag values on dynamic registry creation - Improved DynamicRegistryFlag#OPTIONAL javadocs slightly * Add missing icon to data callback library (#331) * Commit most style changes One of them needs a more specific wording change, so it's going to be done in another commit since that's easier for us Co-authored-by: Ennui Langeweile <[email protected]> * Make documentation for DynamicRegistryFlag more accurate * Improve the javadocs on DynamicRegistryFlag AGAIN accidentally dropped a word guh * BUT WAIT, THERE'S MORE! Hopefully the final style change moment Co-authored-by: Ennui Langeweile <[email protected]> * Implement style change in DynamicRegistryFlagManager Co-authored-by: LambdAurora <[email protected]> * Fix binary incompatibility hopefully? - Added back methods to DynamicMetaRegistry with the same signature as the old ones to avoid binary incompatibility. These are marked as deprecated and should be removed in a breaking/major QSL release. * Remove deprecation annotations on compat. method overloads in DynamicMetaRegistry * Fix: Modify Tag path behavior in Dynamic Registries (#329) * Implement tweak to Tags API to append `tags/` to the start of Dynamic Registries for tag creation that do not already have said path appended to the start of them already. This behavior also exits in FAPI as of the most recent release, and so adding it to QSL unifies the behavior of pure QSL and the upcoming QFAPI release in that regard. This can easily be moved to the Registry API to reduce intra-module requirements, but was put in the Tags API as that's the part of the game that is being modified here. * Move TagManagerLoaderMixin from Tags API to Registry API so that Tags API does not need to depend on Registry API for one very small mixin * Modify mixin injector name to be more descriptive and have `quilt$` prefix for debugging * Revert changes to quilt_tags.mixins.json * Added tests for tag namespace changes * go go gadget license generation --------- Co-authored-by: Ennui Langeweile <[email protected]> * Flip a boolean to sync with FAPI behavior see 2ff57f2 and FabricMC/fabric@d3afe6c * Clean up the dynamic tag test * Add stopguard on registering dynamic registries No, you cannot use the `minecraft` namespace and blow up the world * Ran the licenser. Dear gods that's a lotta copyright year changes wowie * Revert "Ran the licenser. Dear gods that's a lotta copyright year changes wowie" This reverts commit 696a299. --------- Co-authored-by: Lilly Rose Berner <[email protected]> Co-authored-by: Ennui Langeweile <[email protected]> Co-authored-by: LambdAurora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing I noticed 🦫