[1.20.2] Compress the entity library and rename the entity module to entity_extensions
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entity library had way too many 1 or 2 class modules. This compresses most of those modules into the `entity_extensions` library (renamed from `entity` to match `block_extensions` et al)
TheGlitch76
force-pushed
the
entity-refactor
branch
from
4832877
to
c232be0
Compare
EnnuiL
suggested changes
Aug 19, 2023
library/entity/entity_extensions/src/main/resources/quilt_entity_extensions.accesswidener
Outdated
Show resolved
Hide resolved
library/entity/entity_extensions/src/main/resources/quilt_entity_extensions.accesswidener
Show resolved
Hide resolved
library/entity/entity_extensions/src/testmod/resources/quilt.mod.json
Outdated
Show resolved
Hide resolved
library/entity/entity_extensions/src/testmod/resources/quilt.mod.json
Outdated
Show resolved
Hide resolved
library/entity/entity_extensions/src/testmod/resources/quilt.mod.json
Outdated
Show resolved
Hide resolved
library/entity/entity_extensions/src/testmod/resources/quilt_entity_test.mixins.json
Outdated
Show resolved
Hide resolved
EnnuiL
added
library: entity
|
Ennui, I disagree--QuiltExtendedSpawnDataEntity is the definition of an entity extension, and the code footprint is pretty small. |
hm, fair enough |
OroArmor
approved these changes
Aug 28, 2023
Co-authored-by: Ennui Langeweile <[email protected]>
EnnuiL
suggested changes
Sep 4, 2023
...ions/src/main/java/org/quiltmc/qsl/entity/extensions/mixin/PointOfInterestTypesAccessor.java
Show resolved
Hide resolved
...extensions/src/main/java/org/quiltmc/qsl/entity/extensions/mixin/networking/EntityMixin.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Hm, something that I'm wondering; Why replace the AW with the mixin accessor? i'm just curious about the reasoning
Merged
Co-authored-by: Ennui Langeweile <[email protected]>
|
This was merged in manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entity library had way too many 1 or 2 class modules. This compresses most of those modules into the
entity_extensionslibrary (renamed fromentityto matchblock_extensionset al).I feel that this structure more closely follows the size and scope of modules in our other libraries (and the kind of size we want overall), but I'm absolutely open to feedback on reverting parts or organizing it differently.