Update to QLoader 0.20.1, migrate RegSync config to ReflectiveConfig
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnnuiL
added
library: core
|
Tested? if so i will approve |
In-dev? Yes; On production? Not yet, which is why I didn't give it |
|
Just tested it on prod; Can confirm it works |
EnnuiL
added
s: tested
EnnuiL
requested review from
ix0rai and
a team
and removed request for
LambdAurora and
ix0rai
TheGlitch76
approved these changes
Sep 2, 2023
|
This PR has now entered a Final Comment Period of 3 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantages of Quilt Loader 0.20.1's new config API in order to get rid a lot of Quilt Registry Sync's janky code that worked around
WrappedConfig's fundamental flaw(
there was an attempt to add labels to this PR but uh, terrible internet connection won't let me to and i need to wake up earlier tomorrowupdate: nvm)