Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0040: Create proposal for a general mappings library/project #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OroArmor
Copy link
Member

No description provided.

@OroArmor OroArmor changed the title Create proposal Create proposal for a general mappings library/project Sep 21, 2021
@BasiqueEvangelist
Copy link

Why not just use Mapping IO?

@OroArmor
Copy link
Member Author

  1. Mappings IO has a different scope than this proposed project.
  2. Mappings IO is not in house. I would like something in house. As well, the rfc covers how the projects will still be published separately, but be integrated in one larger project to reduce code duplication.

@TropheusJ
Copy link

I don't think not in house is a good excuse to not use something. If it works, we should use it. I can't really give input on that though since I don't know what exactly mappings IO does.

Otherwise, this looks like a good plan to me.

@AlsoSylv
Copy link

AlsoSylv commented Oct 3, 2021

If code is constantly being duplicated between tools I see no reason not to have them as one project instead

@TheGlitch76 TheGlitch76 self-requested a review October 3, 2021 01:08
@TheGlitch76
Copy link
Member

Mappings IO is not in house. I would like something in house. As well, the rfc covers how the projects will still be published separately, but be integrated in one larger project to reduce code duplication.

This isn't a good justification for not using something. Has mappings-io been investigated? We don't have to keep merging with upstream on it, but have we considered its strengths and weaknesses, and if it could possibly be used in the building of tiny utils?

Copy link

@NoComment1105 NoComment1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion reducing the amount of duplicated code, as well as reducing the amount of different pieces of software used would be good

Copy link
Member

@IotaBread IotaBread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Fabric is changing to use Mapping IO everywhere, for example Loom and Lorenz Tiny have migrated, while in Enigma and Yarn there is an issue/pr to do so. We could use Mapping IO as a starting point for Tiny Utils

@i509VCB i509VCB added draft RFCs in drafting, may not be final in-review RFCs ready to be reviewed and removed draft RFCs in drafting, may not be final labels Nov 20, 2021
@Akarys42 Akarys42 changed the title Create proposal for a general mappings library/project RFC 0040: Create proposal for a general mappings library/project Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review RFCs ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants