Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remote notification config #1547

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Nov 1, 2023

Issue: #1503

Demo:

Screen.Recording.2023-11-02.at.13.59.51.mov

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 5:43pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 5:43pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 5:43pm

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Nov 1, 2023
@mamadoudicko mamadoudicko force-pushed the feat/remote-notification branch from 9efc0a4 to 43a580d Compare November 1, 2023 15:59
@mamadoudicko mamadoudicko force-pushed the feat/remote-notification branch from 43a580d to 44aff5d Compare November 1, 2023 16:02
@mamadoudicko mamadoudicko force-pushed the feat/remote-notification branch from 44aff5d to f5e16d3 Compare November 1, 2023 16:28
@StanGirard
Copy link
Collaborator

@mamadoudicko only on the chat page, not on the homepage :) It should only display to connected users

@StanGirard
Copy link
Collaborator

Mais nice !

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/api/cms/utils/securityQuestion.ts

The code seems to be fine, but make sure that the CmsSecurityQuestions object always has the expected structure and that the axiosInstance.get call is always successful.


Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/api/cms/useCmsApi.ts

The code seems to be fine, but make sure that the getNotificationBanner function is always defined and that it always returns the expected data.


Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/components/NotificationBanner/utils.ts

The code seems to be fine, but make sure that the LocalStorageNotification object always has the expected structure and that the localStorage.getItem and localStorage.setItem calls are always successful.


🔒🔍👍


Powered by Code Review GPT

@StanGirard StanGirard merged commit 867904f into main Nov 2, 2023
7 checks passed
mamadoudicko pushed a commit that referenced this pull request Nov 3, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.104 (2023-11-03)

## What's Changed
* feat: 🎸 docs by @StanGirard in
#1561
* style(prompts): update public prompts dropdown styling by @St-Bloom in
#1563
* feat: add remote notification config by @mamadoudicko in
#1547
* fix: fix button bad children error by @mamadoudicko in
#1564
* style: fix hidden contents by @mamadoudicko in
#1577

## New Contributors
* @St-Bloom made their first contribution in
#1563

**Full Changelog**:
v0.0.103...v0.0.104

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.104 (2023-11-03)

## What's Changed
* feat: 🎸 docs by @StanGirard in
QuivrHQ/quivr#1561
* style(prompts): update public prompts dropdown styling by @St-Bloom in
QuivrHQ/quivr#1563
* feat: add remote notification config by @mamadoudicko in
QuivrHQ/quivr#1547
* fix: fix button bad children error by @mamadoudicko in
QuivrHQ/quivr#1564
* style: fix hidden contents by @mamadoudicko in
QuivrHQ/quivr#1577

## New Contributors
* @St-Bloom made their first contribution in
QuivrHQ/quivr#1563

**Full Changelog**:
QuivrHQ/quivr@v0.0.103...v0.0.104

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants