fix: allow to change model bro brain settings tab

[mamadoudicko]

Issue: #1550
Probably fix [Bug]: Cant select any other models except gpt3.5-turbo#1294

Screen.Recording.2023-11-06.at.11.44.06.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 10:46am
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 10:46am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 10:46am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/components/ModelSelection/ModelSelection.tsx

The code seems to be well written and follows good practices. However, there is a potential issue with the onChange event handler in the register function for the model field. The handleSubmit function is called with false as an argument, which might not be the expected behavior in all cases. Make sure that this is the intended behavior and that it won't cause any unexpected side effects.

register(\"model\", {
  onChange: () => {
    void handleSubmit(false);
  },
})

---

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/hooks/useSettingsTab.ts

1. The updateFormValues function has a setTimeout with a delay of 50ms. This might cause race conditions if the brain object changes within that time frame. Consider using a different approach to ensure that the model value is set correctly.

setTimeout(() => {
  if (brain.model !== undefined && brain.model !== null) {
    setValue(\"model\", brain.model);
  }
}, 50);

2. The handleSubmit function has a lot of responsibilities. It checks for changes, validates the brain name and OpenAI key, updates the brain, and handles errors. Consider breaking it down into smaller functions to improve readability and maintainability.

3. The error handling in the handleSubmit function and setAsDefaultBrainHandler function could be improved. Currently, it just logs the error to the console. Consider providing a more user-friendly error message or handling specific error cases differently.

---

📝🐞⏱️

---

Powered by Code Review GPT