feat: 🎸 sources

[StanGirard]

added sources in front and backend

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:08am
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:08am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2023 11:08am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatDialogueArea/components/ChatDialogue/components/QADisplay/components/MessageRow/components/SourcesButton.tsx

The code is generally well-written and follows good practices. However, there are a few areas that could be improved for better performance and readability.

1. Use of index as key in map function: Using the index as a key in the map function is not recommended as it can lead to unexpected behavior if the items in the list are re-ordered, added, or removed. It would be better to use a unique identifier for each source if one is available.

{sources.split(', ').map((source, index) => (
  <li key={source} className=\"truncate\">{source.trim()}</li>
))}

2. Use of inline styles: Inline styles are generally discouraged as they can make the code harder to read and maintain. It would be better to use CSS classes and define the styles in a separate CSS file.

<div className=\"absolute z-50 min-w-max p-2 bg-white shadow-lg rounded-md border border-gray-200 position-popup\">

In the CSS file:

.position-popup {
  top: `${popupPosition.top}px`;
  left: `${popupPosition.left}px`;
}

Remember to update the state and the CSS file whenever the popupPosition changes.

---

Risk Level 3 - /home/runner/work/quivr/quivr/backend/llm/qa_base.py

1. The openai_api_key and user_openai_api_key are being used in plain text which is a security risk. Consider using environment variables or a secure method to store these keys.

2. The else statement in the _determine_api_key function is not necessary. If the if condition is not met, the function will automatically return the openai_api_key. This can improve readability.

3. The try/except blocks in the generate_stream function are catching all exceptions. It's generally a good practice to catch specific exceptions to avoid hiding bugs.

4. The generate_stream function is quite long and complex. Consider breaking it down into smaller, more manageable functions.

Example code:

    def _determine_api_key(self, openai_api_key, user_openai_api_key):
        \"\"\"If user provided an API key, use it.\"\"\"
        if user_openai_api_key is not None:
            return user_openai_api_key
        return openai_api_key

---

🔑🎨🔍

---

Powered by Code Review GPT