Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(notetaker): hide selected text from searchbar + handle edge cases for AI selection context #3430

Conversation

adityanandanx
Copy link
Contributor

@adityanandanx adityanandanx commented Oct 25, 2024

Description

  • Hide the text added via selection from the searchbar
  • (not needed anymore) Refactor code so as to use react states instead of using the Highlight extension for storing selection content
  • Create custom extension for accepting and declining the generated content.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

image
image
image
image

@adityanandanx adityanandanx marked this pull request as ready for review November 1, 2024 10:51
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. area: frontend Related to frontend functionality or under the /frontend directory labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants