fix: langfuse talk to model #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
AmineDiro
reviewed
Dec 21, 2024
core/quivr_core/rag/quivr_rag.py
Outdated
| @@ -32,6 +33,7 @@ | |||
| ) | |||
|
|
|||
| logger = logging.getLogger("quivr_core") | |||
| langfuse_handler = CallbackHandler() | |||
There was a problem hiding this comment.
This is a global object cant we put it in some class?
There was a problem hiding this comment.
Like this ?
Suggested change
| langfuse_handler = CallbackHandler() | |
| langfuse_service = LangfuseService() | |
| langfuse_handler = langfuse_service.get_handler() | |
With a class defined in utils :
class LangfuseService:
def __init__(self):
self.langfuse_handler = CallbackHandler()
def get_handler(self):
return self.langfuse_handler
AmineDiro
approved these changes
Jan 6, 2025
StanGirard
added a commit
that referenced
this pull request
Jan 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.0.29](core-0.0.28...core-0.0.29) (2025-01-20) ### Features * enabling workflows without rewriting step ([#3549](#3549)) ([bbe1c18](bbe1c18)) * improving the prompts to always refer to 'tasks' instead of 'questions' ([#3528](#3528)) ([e9c72e1](e9c72e1)) * langfuse integration ([#3530](#3530)) ([c4aae1a](c4aae1a)) * langfuse user id ([#3533](#3533)) ([e0ccd3d](e0ccd3d)) * language detection after chunking ([#3532](#3532)) ([d0adb81](d0adb81)) * returning a description of each workflow node ([#3539](#3539)) ([d835fc6](d835fc6)) ### Bug Fixes * langfuse talk to model ([#3535](#3535)) ([9681a9e](9681a9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):