Linting

Gemfile

@@ -1,6 +1,6 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in qyu-store-redis.gemspec
 gemspec

Rakefile

@@ -3,4 +3,4 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

bin/console

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "qyu"
-require "qyu/store/redis"
+require 'bundler/setup'
+require 'qyu'
+require 'qyu/store/redis'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require "qyu/store/redis"
 # require "pry"
 # Pry.start
 
-require "pry"
+require 'pry'
 Pry.start

lib/qyu/store/redis.rb

@@ -1,4 +1,4 @@
-require_relative "./redis/version"
+require_relative './redis/version'
 require_relative './redis/errors'
 require 'json'
 require 'redis'

lib/qyu/store/redis/adapter.rb

@@ -3,6 +3,7 @@
 module Qyu
   module Store
     module Redis
+      # Qyu::Store::Redis::Adapter
       class Adapter < Qyu::Store::Redis.interface
         TYPE = :redis
 

lib/qyu/store/redis/configuration_validator.rb

@@ -1,8 +1,9 @@
 module Qyu
   module Store
     module Redis
+      # Qyu::Store::Redis::ConfigurationValidator
       class ConfigurationValidator
-        REQUIRED_ATTRIBUTES = %i(host port).freeze
+        REQUIRED_ATTRIBUTES = %i[host port].freeze
 
         attr_reader :errors
 

lib/qyu/store/redis/logger.rb

@@ -3,6 +3,7 @@
 module Qyu
   module Store
     module Redis
+      # Qyu::Store::Redis::Logger
       class Logger < ::Logger
       end
     end

lib/qyu/store/redis/version.rb

@@ -1,7 +1,7 @@
 module Qyu
   module Store
     module Redis
-      VERSION = "0.1.0"
+      VERSION = '0.1.0'.freeze
     end
   end
 end

qyu-store-redis.gemspec

@@ -1,43 +1,43 @@
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "qyu/store/redis/version"
+require 'qyu/store/redis/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "qyu-store-redis"
+  spec.name          = 'qyu-store-redis'
   spec.version       = Qyu::Store::Redis::VERSION
-  spec.authors       = ["Mohamed Osama"]
-  spec.email         = ["[email protected]"]
+  spec.authors       = ['Mohamed Osama']
+  spec.email         = ['[email protected]']
 
-  spec.summary       = %q{Redis state store for Qyu https://rubygems.org/gems/qyu}
-  spec.description   = %q{Redis state store for Qyu https://rubygems.org/gems/qyu}
-  spec.homepage      = "https://github.com/FindHotel/qyu-store-redis"
-  spec.license       = "MIT"
+  spec.summary       = 'Redis state store for Qyu https://rubygems.org/gems/qyu'
+  spec.description   = 'Redis state store for Qyu https://rubygems.org/gems/qyu'
+  spec.homepage      = 'https://github.com/FindHotel/qyu-store-redis'
+  spec.license       = 'MIT'
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata["allowed_push_host"] = "TODO: Set to 'http://mygemserver.com'"
+    spec.metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
   else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against ' \
+      'public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "pry", "~> 0.11"
-  spec.add_development_dependency 'pry-byebug', "~> 3.4"
-  spec.add_development_dependency "rspec", "~> 3.5"
-  spec.add_development_dependency "shoulda-matchers", "~> 3.1"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'pry', '~> 0.11'
+  spec.add_development_dependency 'pry-byebug', '~> 3.4'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.5'
+  spec.add_development_dependency 'shoulda-matchers', '~> 3.1'
+  spec.add_development_dependency 'simplecov'
 
-  spec.add_runtime_dependency "redis", "~> 4.0"
-  spec.add_runtime_dependency "redis-namespace", "~> 1.6.0"
+  spec.add_runtime_dependency 'redis', '~> 4.0'
+  spec.add_runtime_dependency 'redis-namespace', '~> 1.6.0'
 end

spec/qyu/store/redis/adapter_spec.rb

@@ -25,7 +25,7 @@
       end
     end
   end
-  
+
   describe 'workflow operations' do
     describe '#persist_workflow' do
       it 'stores workflow on redis' do
@@ -42,7 +42,7 @@
         expect { adapter.persist_workflow('test-workflow', {}) }.to raise_error(Qyu::Store::Redis::Errors::WorkflowNotUnique)
       end
     end
-    
+
     describe '#find_workflow' do
       let(:workflow) { adapter.persist_workflow('test-workflow', {}) }
 
@@ -106,12 +106,12 @@
     describe '#persist_job' do
       let(:workflow) { adapter.persist_workflow('test-workflow', {}) }
 
-      it { expect { adapter.persist_job(workflow, { payload: 'foo' }) }.to change { adapter.count_jobs } }
+      it { expect { adapter.persist_job(workflow, payload: 'foo') }.to change { adapter.count_jobs } }
     end
 
     describe '#find_job' do
       let(:workflow) { adapter.persist_workflow('test-workflow', {}) }
-      let(:job) { adapter.persist_job(workflow, { 'payload' => 'foo' }) }
+      let(:job) { adapter.persist_job(workflow, 'payload' => 'foo') }
 
       it 'returns workflow' do
         found_job = adapter.find_job(job['id'])
@@ -122,8 +122,8 @@
     describe '#select_jobs' do
       context 'when exists jobs' do
         let(:workflow) { adapter.persist_workflow('test-workflow', {}) }
-        let!(:job) { adapter.persist_job(workflow, { 'payload' => 'foo' }) }
-        let!(:job2) { adapter.persist_job(workflow, { 'payload' => 'bar' }) }
+        let!(:job) { adapter.persist_job(workflow, 'payload' => 'foo') }
+        let!(:job2) { adapter.persist_job(workflow, 'payload' => 'bar') }
 
         it 'returns the correct quantity' do
           selected_jobs = adapter.select_jobs(2, 0)
@@ -156,8 +156,8 @@
     describe '#count_jobs' do
       before do
         workflow = adapter.persist_workflow('test-workflow', {})
-        adapter.persist_job(workflow, { payload: 'foo' })
-        adapter.persist_job(workflow, { payload: 'foo2' })
+        adapter.persist_job(workflow, payload: 'foo')
+        adapter.persist_job(workflow, payload: 'foo2')
       end
 
       it { expect(adapter.count_jobs).to eq 2 }
@@ -166,7 +166,7 @@
     describe '#delete_job' do
       context 'when job exists' do
         let(:workflow) { adapter.persist_workflow('test-workflow', {}) }
-        let!(:job) { adapter.persist_job(workflow, { 'payload' => 'foo' }) }
+        let!(:job) { adapter.persist_job(workflow, 'payload' => 'foo') }
 
         it 'returns true' do
           deleted = adapter.delete_job(job['id'])
@@ -185,7 +185,7 @@
 
   describe 'task operations' do
     let(:workflow) { adapter.persist_workflow('test-workflow', {}) }
-    let(:job) { adapter.persist_job(workflow, { payload: 'foo' }) }
+    let(:job) { adapter.persist_job(workflow, payload: 'foo') }
     let(:task_attributes) do
       {
         'name' => 'task_test',
@@ -304,7 +304,7 @@
 
           tasks = adapter.select_tasks_by_job_id(job['id'])
 
-          task_ids = tasks.map{ |task| task['id'] }
+          task_ids = tasks.map { |task| task['id'] }
           expect(task_ids).to match_array([task1_id, task2_id])
         end
       end
@@ -351,7 +351,7 @@
 
         it 'unlock task' do
           adapter.unlock_task!(task_id, lease_token)
-          
+
           task = adapter.find_task(task_id)
 
           expect(task['locked_by']).to be_empty
@@ -369,7 +369,7 @@
 
     describe '#renew_lock_lease' do
       let(:lease_time) { 60 }
-      
+
       context 'when task exists' do
         let(:task_id) { adapter.find_or_persist_task(*task_attributes.values) }
         let(:lease_token) { adapter.lock_task!(task_id, lease_time)[0] }
@@ -394,7 +394,7 @@
 
     describe '#update_status' do
       let(:status) { 'completed' }
-      
+
       context 'when task exists' do
         let(:task_id) { adapter.find_or_persist_task(*task_attributes.values) }
 
@@ -405,7 +405,7 @@
 
         it 'set new status on task' do
           updated = adapter.update_status(task_id, status)
-          
+
           task = adapter.find_task(task_id)
 
           expect(task['status']).to eq(status)
@@ -421,5 +421,4 @@
       end
     end
   end
-
 end

spec/qyu/store/redis_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe Qyu::Store::Redis do
-  it "has a version number" do
+  it 'has a version number' do
     expect(Qyu::Store::Redis::VERSION).not_to be nil
   end
 

spec/spec_helper.rb

@@ -6,7 +6,7 @@
 
 SimpleCov.start
 
-require "qyu/store/redis"
+require 'qyu/store/redis'
 
 require 'pry'
 
@@ -21,7 +21,6 @@
     c.syntax = :expect
   end
 
-
   config.before(:each) do
     # ignore_puts
     reset_config
@@ -54,7 +53,7 @@ def redis_config
 
 def clean_up_redis
   redis = Redis.new(redis_config)
-  namespaced_redis = Redis::Namespace.new(redis_config[:namespace], :redis => redis)
+  namespaced_redis = Redis::Namespace.new(redis_config[:namespace], redis: redis)
   if (keys = namespaced_redis.keys) && !keys.empty?
     namespaced_redis.del(keys)
   end