Skip to content

Commit

Permalink
apacheGH-36885: [Java][Docs] Add substrait dependency to maven build …
Browse files Browse the repository at this point in the history
…profiles (apache#36899)

### Rationale for this change

The Java JNI dataset module recently included the Substrait module as a dependency. The dependency was added to the CI scripts, but not added to the build profiles and documentation yet.

### What changes are included in this PR?

- Update maven build profiles
- Update Java build documentation

### Are these changes tested?

I tested locally on MacOS and was able to reproduce + fix with this change.

### Are there any user-facing changes?

No
* Closes: apache#36885

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
danepitkin authored and R-JunmingChen committed Aug 20, 2023
1 parent 98df0f9 commit a2fade7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/source/developers/java/building.rst
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ CMake
-DARROW_ORC=ON \
-DARROW_PARQUET=ON \
-DARROW_S3=ON \
-DARROW_SUBSTRAIT=ON \
-DARROW_USE_CCACHE=ON \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_LIBDIR=lib/<your system's architecture> \
Expand Down Expand Up @@ -258,6 +259,7 @@ CMake
-DARROW_ORC=OFF ^
-DARROW_PARQUET=ON ^
-DARROW_S3=ON ^
-DARROW_SUBSTRAIT=ON ^
-DARROW_USE_CCACHE=ON ^
-DARROW_WITH_BROTLI=ON ^
-DARROW_WITH_LZ4=ON ^
Expand Down
2 changes: 2 additions & 0 deletions java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,7 @@
-DARROW_ORC=${ARROW_ORC}
-DARROW_PARQUET=${ARROW_PARQUET}
-DARROW_S3=ON
-DARROW_SUBSTRAIT=${ARROW_DATASET}
-DARROW_USE_CCACHE=ON
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_LIBDIR=lib/${os.detected.arch}
Expand Down Expand Up @@ -1131,6 +1132,7 @@
-DARROW_ORC=${ARROW_ORC}
-DARROW_PARQUET=${ARROW_PARQUET}
-DARROW_S3=ON
-DARROW_SUBSTRAIT=${ARROW_DATASET}
-DARROW_USE_CCACHE=ON
-DARROW_WITH_BROTLI=ON
-DARROW_WITH_LZ4=ON
Expand Down

0 comments on commit a2fade7

Please sign in to comment.